Date: Mon, 11 Mar 2024 11:07:41 +0000 From: Nuno Teixeira <eduardo@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, Vladimir Druzenko <vvd@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 021fcd36af22 - main - games/coffeebreak: Move man pages to share/man Message-ID: <CAFDf7UL1tygiwKnjpZH69Gm6sdJs7myi%2BSwVCU9Lwj3YOR_sKg@mail.gmail.com> In-Reply-To: <Ze5pvZ23YQiyRjyH@FreeBSD.org> References: <202403090831.4298VJo6024021@gitrepo.freebsd.org> <Ze16dMKKJxs9IN3t@FreeBSD.org> <CAFDf7UKq-onz-dbR=pm03Ji1FHb-u81Cidohi-be-EnVvYsGUQ@mail.gmail.com> <CAFDf7UJnP66UooFnRLxnhJS_B0j3hDfc%2Bc7uwh%2BGkNXNB_xukA@mail.gmail.com> <CAFDf7UKQ9ibp=46YuZRVpK-HDkeU92HKMkjWst1-t7oSMOBggw@mail.gmail.com> <Ze3YBw8CwWTEDxYg@FreeBSD.org> <32f6aa31-5d2e-401f-9c2c-eec41c14e60f@freebsd.org> <4knrc5ywvwupkrkzgevfpbclp3hhq5eojt6l4iigwn2w64krre@cfbbk7q6efg3> <Ze5pvZ23YQiyRjyH@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Fixed in 1128357fc9df commit.
Thanks all,
Alexey Dokuchaev <danfe@freebsd.org> escreveu (segunda, 11/03/2024 =C3=A0(s=
) 02:17):
>
> On Sun, Mar 10, 2024 at 09:31:19PM +0100, Mathieu Arnold wrote:
> > On Sun, Mar 10, 2024 at 08:33:55PM +0300, Vladimir Druzenko wrote:
> > > 10.03.2024 18:55, Alexey Dokuchaev =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > > > On Sun, Mar 10, 2024 at 10:47:07AM +0000, Nuno Teixeira wrote:
> > > > > (...)
> > > > >
> > > > > Works fine:
> > > > >
> > > > > +MAKE_ARGS=3D PREFIX=3D${PREFIX} MANDIR=3D${STAGEDIR}${PREFIX=
}/share/man
> > > > >
> > > > > What do you think? This way it is nicely simplified without patch
> > > > > or sed.
> > > >
> > > > Yes, this is what I had in mind.
> > >
> > > I tested same for other ports - doesn't work if Makefile have line:
> > > MANDIR=3D XXX but work if it have: MANDIR?=3D XXX
>
> You don't have to *test* this as it were some kind of magic, this is
> well known and documented make(1) behaviour. Could you be confusing
> with MAKE_ENV perhaps?
>
> > Variables passed as arguments will override variables set with =3D or ?=
=3D
> > Variables in the environemnt will override variables set with ?=3D
>
> Right. Alas, apparently this is still needs to be explained even to
> some seasoned ports committers. :-/
>
> ./danfe
--=20
Nuno Teixeira
FreeBSD Committer (ports)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UL1tygiwKnjpZH69Gm6sdJs7myi%2BSwVCU9Lwj3YOR_sKg>