From owner-freebsd-current@freebsd.org Thu Oct 17 21:05:17 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0DABC15D9DB; Thu, 17 Oct 2019 21:05:17 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46vMBN0NCfz3Dxq; Thu, 17 Oct 2019 21:05:15 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x842.google.com with SMTP id 3so5774077qta.1; Thu, 17 Oct 2019 14:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xcjwpiGFp2pwuGwbSMvqsfdwJbz/8IDL+lBcWXf8upQ=; b=OXHHdnokwoyE84mrQe6hpftgbvHihjnbPjuXCmUfXrUqcxrreweM2CYMYagefy7iz0 lUGdcwQokZ7G1qFK7Oa+ZUTcufsTJzc5yuXoWIUy0LHNVq0JxbilzLiPGLEl7zpiNY3x 7G05eOlPcaJYL8avx4zmrJ/3iKjDr+FLYrZegvFGCuYaCY1rajjpnRImsgnLvGH8ztCz /uHcJu+4u+vXNlNBw/Kwju+YrfFmEtdMSN6OlS1XlGNimFoORKxFVAb9qpGWz5kPibqi Y0qjDL9JNhKXi+VkhODopTdzpbsspDtdH62ho3iEb0GGgLL0QdjSDjfxNMOnWOlXgD4/ nLkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=xcjwpiGFp2pwuGwbSMvqsfdwJbz/8IDL+lBcWXf8upQ=; b=CH6587rPNBkj9wchm4TEA8FgYoIGQ1hBVZmPlKacZQhQ97iiVjObP+lp8+RCCj8cXZ AWn8UbRaKRYT4NKgIp9NeUkUbiTURkxFdzkHKxhCNcS1el4AIreswMNkISGhqESHnnMt eME3XPANZo3KbSj3/oANXKmNaBmqtLbxK1t1uSw/+aB6t2aS0nXTLU3bDf1pUxC4SJMu AakI7QWmdJpYZVlW8kqdcyVoNXgcHr+KMd5zyw8026Db7lXf/gEYIFk2GSrMvotf2gWf uWuBm2aelhgNGqJd0VffHN/h6kbraW69xgO+KcPg1EhPuwZH4y1n7g4HRpeedQv+Kyu9 XbqA== X-Gm-Message-State: APjAAAVmb7WWBlUH2buQIYqedCYWm1po8WzrDeM4bC+qHhRWCRAswJ5k FIieHUQrTUntXvSwlc/3uDg= X-Google-Smtp-Source: APXvYqyKdudSWIn+xrS71SQEXwsgTME44dMlu5dzOn5KxLary52Vsh7W1L1Wb36x4LxUdAguMh3pLw== X-Received: by 2002:ac8:6ed9:: with SMTP id f25mr5906824qtv.207.1571346314967; Thu, 17 Oct 2019 14:05:14 -0700 (PDT) Received: from raichu (toroon0560w-lp130-05-69-158-183-252.dsl.bell.ca. [69.158.183.252]) by smtp.gmail.com with ESMTPSA id 92sm1675028qte.30.2019.10.17.14.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 14:05:12 -0700 (PDT) Sender: Mark Johnston Date: Thu, 17 Oct 2019 17:05:10 -0400 From: Mark Johnston To: Niclas Zeising Cc: Neel Chauhan , Mateusz Guzik , Evilham , FreeBSD Current , owner-freebsd-current@freebsd.org Subject: Re: DRM-current-kmod is still a problem at r353339 Message-ID: <20191017210510.GC6447@raichu> References: <99c89ca0-462c-f4c7-fa07-6f61e9d39d66@acm.org> <3bb2e410-51dd-bc3f-7660-41a4683551b3@daemonic.se> <20191017195347.GB6447@raichu> <53ff1ac5-c7e8-1b6c-bd43-481eaef61120@daemonic.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53ff1ac5-c7e8-1b6c-bd43-481eaef61120@daemonic.se> User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 46vMBN0NCfz3Dxq X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=OXHHdnok; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::842 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.19 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[freebsd]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2.4.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.49)[ip: (2.17), ipnet: 2607:f8b0::/32(-2.47), asn: 15169(-2.10), country: US(-0.05)]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Oct 2019 21:05:17 -0000 On Thu, Oct 17, 2019 at 10:31:12PM +0200, Niclas Zeising wrote: > On 2019-10-17 21:53, markj@freebsd.org wrote: > > On Thu, Oct 17, 2019 at 03:03:51PM +0200, Niclas Zeising wrote: > >> On 2019-10-16 18:57, Neel Chauhan wrote: > >>> While drm-current-kmod worked for a little while, it broke with r353645. > >>> > >>> https://i.imgur.com/Q5nYZf2.jpg > >>> > >>> I'm using the same HP Spectre that I used earlier (where it worked and > >>> where it panicked). > >>> > >> > >> That commit looks unrelated, it touches the wbwd and superio drivers, > >> nothing else. Any chance you can bisect exactly which revision that > >> caused the new issues? > > > > I believe it was the recent work on the vm page busy state, r353539 > > specifically. This patch should fix it; we don't yet have a > > __FreeBSD_version number bump on which to gate the patch. > > > > diff --git a/linuxkpi/gplv2/src/linux_page.c b/linuxkpi/gplv2/src/linux_page.c > > index e2b85c45c..060ae85ed 100644 > > --- a/linuxkpi/gplv2/src/linux_page.c > > +++ b/linuxkpi/gplv2/src/linux_page.c > > @@ -239,7 +239,7 @@ retry: > > page = vm_page_lookup(devobj, i); > > if (page == NULL) > > continue; > > - if (vm_page_sleep_if_busy(page, "linuxkpi")) > > + if (!vm_page_busy_acquire(page, VM_ALLOC_WAITFAIL)) > > goto retry; > > cdev_pager_free_page(devobj, page); > > } > > Hi! > Hopefully someone can confirm that this patch to drm-current-kmod or > drm-devel-kmod fixes the issue. I won't be able to work on this before > the weekend at the earliest, I'm afraid. > Mark, is it possible to get a belated version bump for this fix, and > what changed to require it? I committed the bump and verified the patch on amdgpu. Here are some PRs for the drivers: https://github.com/FreeBSDDesktop/kms-drm/pull/180 https://github.com/FreeBSDDesktop/kms-drm/pull/181