Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Dec 2013 10:28:46 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Roger Pau Monne <roger.pau@citrix.com>
Cc:        xen-devel@lists.xen.org, julien.grall@citrix.com, freebsd-xen@freebsd.org, freebsd-current@freebsd.org, kib@freebsd.org, gibbs@freebsd.org
Subject:   Re: [PATCH v7 13/19] xen: introduce flag to disable the local apic
Message-ID:  <201312241028.46166.jhb@freebsd.org>
In-Reply-To: <1387479296-33389-14-git-send-email-roger.pau@citrix.com>
References:  <1387479296-33389-1-git-send-email-roger.pau@citrix.com> <1387479296-33389-14-git-send-email-roger.pau@citrix.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, December 19, 2013 1:54:50 pm Roger Pau Monne wrote:
> PVH guests don't have an emulated lapic.

Since the tests all use '!lapic_disabled' I think I would prefer to flip the 
name to 'lapic_valid' and have it default to true.  It would just be a 
cosmetic change to the current patch, but I think it is more readable long-
term.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312241028.46166.jhb>