From owner-cvs-src-old@FreeBSD.ORG Wed Jul 14 14:31:36 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B020106567A for ; Wed, 14 Jul 2010 14:31:36 +0000 (UTC) (envelope-from gibbs@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id EC6718FC15 for ; Wed, 14 Jul 2010 14:31:35 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o6EEVZmW053535 for ; Wed, 14 Jul 2010 14:31:35 GMT (envelope-from gibbs@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o6EEVZXe053534 for cvs-src-old@freebsd.org; Wed, 14 Jul 2010 14:31:35 GMT (envelope-from gibbs@repoman.freebsd.org) Message-Id: <201007141431.o6EEVZXe053534@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to gibbs@repoman.freebsd.org using -f From: "Justin T. Gibbs" Date: Wed, 14 Jul 2010 14:31:18 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/aic7xxx aic79xx.reg aic7xxx.reg src/sys/dev/aic7xxx/aicasm aicasm_gram.y X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2010 14:31:36 -0000 gibbs 2010-07-14 14:31:18 UTC FreeBSD src repository Modified files: sys/dev/aic7xxx aic79xx.reg aic7xxx.reg sys/dev/aic7xxx/aicasm aicasm_gram.y Log: SVN rev 210055 on 2010-07-14 14:31:18Z by gibbs Correct logic bug in aicasm's undefined register bit access detection code. The code in question verifies that all register write operations only change bits that are defined (in the register definition file) for that effected register. The bug effectively disabled this checking. o Fix the check by testing the opcode against all supported read ("and" based) operands. o Add missing bit definitions to the aic7xxx and aic79xx register definition files so that the warning (treated as a fatal error) does not spuriously fire. Reported by: Pawel Worach MFC after: 1 week Revision Changes Path 1.20 +1 -0 src/sys/dev/aic7xxx/aic79xx.reg 1.48 +1 -0 src/sys/dev/aic7xxx/aic7xxx.reg 1.27 +10 -5 src/sys/dev/aic7xxx/aicasm/aicasm_gram.y