Date: Fri, 20 Aug 2021 16:22:39 +0000 From: bugzilla-noreply@freebsd.org To: toolchain@FreeBSD.org Subject: [Bug 257829] lldb crashes with asio acceptor::accept Message-ID: <bug-257829-29464-yKfLgNwCmu@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-257829-29464@https.bugs.freebsd.org/bugzilla/> References: <bug-257829-29464@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D257829 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Da949c6a0d6c83994471e33c8ea60f1509= e691f6c commit a949c6a0d6c83994471e33c8ea60f1509e691f6c Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2021-08-16 16:56:41 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2021-08-20 16:21:46 +0000 Apply upstream lldb fix for unhandled Error causing abort Merge commit 5033f0793fe6 from llvm git (by Dimitry Andric): [lldb] Avoid unhandled Error in TypeSystemMap::GetTypeSystemForLangua= ge When assertions are turned off, the `llvm::Error` value created at the start of this function is overwritten using the move-assignment operator, but the success value is never checked. Whenever a TypeSyst= em cannot be found or created, this can lead to lldb core dumping with: Program aborted due to an unhandled Error: Error value was Success. (Note: Success values must still be chec= ked prior to being destroyed). Fix this by not creating a `llvm::Error` value in advance, and direct= ly returning the result of `llvm::make_error` instead, whenever an error= is encountered. See also: <https://bugs.freebsd.org/253881>; and <https://bugs.freebsd.org/257829>. Reviewed By: teemperor Differential Revision: https://reviews.llvm.org/D108088 Reported by: dmgk, ota@j.email.ne.jp PR: 253881, 257829 (cherry picked from commit c1a540709a83f810aa47380b946552ab20020374) .../llvm-project/lldb/source/Symbol/TypeSystem.cpp | 90 +++++++++---------= ---- 1 file changed, 38 insertions(+), 52 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-257829-29464-yKfLgNwCmu>