Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 3 Dec 2021 22:27:35 GMT
From:      Scott Long <scottl@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: bca8e8c00c4e - main - Fix "set but not used" in arcmsr
Message-ID:  <202112032227.1B3MRZad085526@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by scottl:

URL: https://cgit.FreeBSD.org/src/commit/?id=bca8e8c00c4ed9d5a52943f3b58d6f2238f4dd74

commit bca8e8c00c4ed9d5a52943f3b58d6f2238f4dd74
Author:     Scott Long <scottl@FreeBSD.org>
AuthorDate: 2021-12-03 22:22:47 +0000
Commit:     Scott Long <scottl@FreeBSD.org>
CommitDate: 2021-12-03 22:26:57 +0000

    Fix "set but not used" in arcmsr
    
    Sponsored by: Rubicon Communications, LLC ("Netgate")
---
 sys/dev/arcmsr/arcmsr.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/sys/dev/arcmsr/arcmsr.c b/sys/dev/arcmsr/arcmsr.c
index 31d12f0ffd40..1799e1042316 100644
--- a/sys/dev/arcmsr/arcmsr.c
+++ b/sys/dev/arcmsr/arcmsr.c
@@ -622,12 +622,8 @@ static int arcmsr_resume(device_t dev)
 */
 static void arcmsr_async(void *cb_arg, u_int32_t code, struct cam_path *path, void *arg)
 {
-	struct AdapterControlBlock *acb;
 	u_int8_t target_id, target_lun;
-	struct cam_sim *sim;
 
-	sim = (struct cam_sim *) cb_arg;
-	acb =(struct AdapterControlBlock *) cam_sim_softc(sim);
 	switch (code) {
 	case AC_LOST_DEVICE:
 		target_id = xpt_path_target_id(path);
@@ -635,7 +631,6 @@ static void arcmsr_async(void *cb_arg, u_int32_t code, struct cam_path *path, vo
 		if((target_id > ARCMSR_MAX_TARGETID) || (target_lun > ARCMSR_MAX_TARGETLUN)) {
 			break;
 		}
-	//	printf("%s:scsi id=%d lun=%d device lost \n", device_get_name(acb->pci_dev), target_id, target_lun);
 		break;
 	default:
 		break;
@@ -5073,14 +5068,13 @@ static int arcmsr_probe(device_t dev)
 static int arcmsr_shutdown(device_t dev)
 {
 	u_int32_t  i;
-	u_int32_t intmask_org;
 	struct CommandControlBlock *srb;
 	struct AdapterControlBlock *acb=(struct AdapterControlBlock *)device_get_softc(dev);
 
 	/* stop adapter background rebuild */
 	ARCMSR_LOCK_ACQUIRE(&acb->isr_lock);
 	/* disable all outbound interrupt */
-	intmask_org = arcmsr_disable_allintr(acb);
+	arcmsr_disable_allintr(acb);
 	arcmsr_stop_adapter_bgrb(acb);
 	arcmsr_flush_adapter_cache(acb);
 	/* abort all outstanding command */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202112032227.1B3MRZad085526>