Date: Sun, 21 Aug 2011 18:51:44 -0400 (EDT) From: hag@linnaean.org To: freefall-gnats@linnaean.org Subject: ports/159977: news/inn doesn't package its examples Message-ID: <20110821225144.52533630C5@perdition.linnaean.org> Resent-Message-ID: <201108212300.p7LN0N3w084860@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 159977 >Category: ports >Synopsis: news/inn doesn't package its examples >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Aug 21 23:00:23 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Daniel Hagerty >Release: FreeBSD 8.2-RELEASE-p2 amd64 >Organization: I can't find my organization! >Environment: System: FreeBSD yall.linnaean.org 8.2-RELEASE-p2 FreeBSD 8.2-RELEASE-p2 #0: Mon Aug 15 17:33:19 EDT 2011 hag@yall.linnaean.org:/usr/src/sys/amd64/compile/LINNAEAN64 amd64 Architecture: amd64 Machine: amd64 >Description: The inn package doesn't package most of the contents of share/examples/inn, but attempts to use them in exec/unexec portions of the package list, producing errors for binary package installations on systems where there is no existing configuration in /usr/local/news/etc. Users looking for an example configuration installed by the package won't find one. There are some indications of intent here, but I can't figure out what it was: with the fix below, the plist line @unexec for f in %%ETCFILES%%; do rm -f %D/%%EXAMPLESDIR%%/${f}; done is presumably redundant. However, the ETCFILES don't exist in the package at all, so I'm a bit puzzled how this line did anything useful previously. >How-To-Repeat: $ pkg_add inn-2.4.6_1.tbz ===> Checking for old database files cp: /usr/local/share/examples/inn/actsync.cfg: No such file or directory cp: /usr/local/share/examples/inn/actsync.ign: No such file or directory cp: /usr/local/share/examples/inn/buffindexed.conf: No such file or directory [ more along these lines ] pkg_add: command 'for f in actsync.cfg actsync.ign buffindexed.conf control.ctl cycbuff.conf distrib.pats expire.ctl incoming.conf inn.conf innfeed.conf innreport.conf innwatch.ctl moderators motd.news news2mail.cf newsfeeds nnrpd.track nntpsend.ctl ovdb.conf overview.fmt passwd.nntp radius.conf readers.conf sasl.conf storage.conf subscriptions; do [ -f /usr/local/news/etc/${f} ] || cp -fp /usr/local/share/examples/inn/${f} /usr/local/news/etc/${f}; done' failed >Fix: Apply patch below, and rebuild package. --- news/inn/pkg-plist.orig 2011-08-21 16:35:32.000000000 -0400 +++ news/inn/pkg-plist 2011-08-21 17:48:53.839773752 -0400 @@ -184,7 +184,34 @@ %%WITH_TAGGED_HASH%%@unexec rm -f %D/%%EXAMPLESDIR%%/db/history.pag 2> /dev/null || true @comment -------------------------------------------------------------- @unexec for f in %%ETCFILES%%; do if cmp -s %%ETCDIR%%/${f} %D/%%EXAMPLESDIR%%/${f}; then rm -f %%ETCDIR%%/${f}; fi; done +%%EXAMPLESDIR%%/actsync.cfg +%%EXAMPLESDIR%%/actsync.ign +%%EXAMPLESDIR%%/buffindexed.conf +%%EXAMPLESDIR%%/control.ctl +%%EXAMPLESDIR%%/cycbuff.conf +%%EXAMPLESDIR%%/distrib.pats +%%EXAMPLESDIR%%/expire.ctl +%%EXAMPLESDIR%%/incoming.conf +%%EXAMPLESDIR%%/inn.conf +%%EXAMPLESDIR%%/innfeed.conf +%%EXAMPLESDIR%%/innreport.conf +%%EXAMPLESDIR%%/innwatch.ctl +%%EXAMPLESDIR%%/moderators +%%EXAMPLESDIR%%/motd.news +%%EXAMPLESDIR%%/news2mail.cf +%%EXAMPLESDIR%%/newsfeeds +%%EXAMPLESDIR%%/nnrpd.track +%%EXAMPLESDIR%%/nntpsend.ctl +%%EXAMPLESDIR%%/ovdb.conf +%%EXAMPLESDIR%%/overview.fmt +%%EXAMPLESDIR%%/passwd.nntp +%%EXAMPLESDIR%%/radius.conf +%%EXAMPLESDIR%%/readers.conf +%%EXAMPLESDIR%%/sasl.conf +%%EXAMPLESDIR%%/storage.conf +%%EXAMPLESDIR%%/subscriptions @unexec for f in %%ETCFILES%%; do rm -f %D/%%EXAMPLESDIR%%/${f}; done +@exec mkdir %%ETCDIR%% @exec for f in %%ETCFILES%%; do [ -f %%ETCDIR%%/${f} ] || cp -fp %D/%%EXAMPLESDIR%%/${f} %%ETCDIR%%/${f}; done @comment -------------------------------------------------------------- @dirrm %%EXAMPLESDIR%%/db >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110821225144.52533630C5>