From owner-svn-src-head@freebsd.org Sun May 29 22:16:58 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 047B6B54354; Sun, 29 May 2016 22:16:58 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x22e.google.com (mail-pf0-x22e.google.com [IPv6:2607:f8b0:400e:c00::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CA8FA1F55; Sun, 29 May 2016 22:16:57 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x22e.google.com with SMTP id g64so58438277pfb.2; Sun, 29 May 2016 15:16:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=IrYtQXCZZXtAiWqBxUQRdd1DXsyRuRnKecGwtqSOibA=; b=o6q4tWHT8Nlh8fdtMBo6FzX9nNh5lar4P2XKD9ue4s3zgoGFUM12O3l6Du324Hej+H cpqtbd5VtKKucKvjF0mw9aN8uTNQiLsWdOXSfbAqps6vmS7cq0Qk2V/8x9ubNVpUbA6O xFQA1YwmgzFtoYOhWOsP8gu7ykZFvoPYHfNR+yDYZGxA5hynwT0c6Q7IevWa04Xn/dnZ UTt2fNknjGHe5+hs5Y/BG4z6saJ6XRP/ZX0kzwrn9zlbQgEm3OmzSwRD3mvsDf6ucEa3 2mV5z+eOmz0MVQGh/iez00iabArIv9rtK6//TeZespJ7QUOOYHuIUDIkGkZcOIDaXSlA Md7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=IrYtQXCZZXtAiWqBxUQRdd1DXsyRuRnKecGwtqSOibA=; b=kgishIeGyZqTlJrAzwnw3MRLtt0+BhbGr+Hw6FjBxPXTfgptrVdZXOs/mDY+TAXIZ5 /WKSdUmOaf1kHH+DFwmXiYaOHnYoFMuICB9x1R6VzEhktrhhjwyqLJfEWMibsvcOilH0 uIayGK1lxV431DgjBX2trGUznXb+TsJ2neRnxwEVoCGQXBfQakOeImBOSVZXuWQaVzAT fpc6Cmuay7E0eJOejaW9Npn9k9r7RZx3mKIEwR6Xt9xb1xYWqDCImisidpNmbuptj2ev x+NClHW2ZvTm1L9AF14ehBbqdfRvJIC/tEdvfb1VxgJELLo3j4V73OA9GIOMrl4SgU6o DRbw== X-Gm-Message-State: ALyK8tIBhewjy7bgfXBjCuqSHM6qfgORz3Z3fFGFhI5BYV4aWF9aGQN8Y6pAj7+XiRcr/A== X-Received: by 10.98.1.6 with SMTP id 6mr41618292pfb.155.1464560217354; Sun, 29 May 2016 15:16:57 -0700 (PDT) Received: from [21.183.163.76] ([172.56.42.229]) by smtp.gmail.com with ESMTPSA id b19sm27831493pfb.55.2016.05.29.15.16.56 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 29 May 2016 15:16:56 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r300973 - head/usr.sbin/rpcbind From: Ngie Cooper X-Mailer: iPhone Mail (13F69) In-Reply-To: <9E1A1DDD-974B-481B-B659-BC099C5C0262@lists.zabbadoz.net> Date: Sun, 29 May 2016 15:16:55 -0700 Cc: Garrett Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <8A6B49EA-4551-4F7C-8332-C6E5B59A4F28@gmail.com> References: <201605292028.u4TKS1iJ017186@repo.freebsd.org> <9E1A1DDD-974B-481B-B659-BC099C5C0262@lists.zabbadoz.net> To: "Bjoern A. Zeeb" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 May 2016 22:16:58 -0000 > On May 29, 2016, at 14:52, Bjoern A. Zeeb = wrote: >=20 >=20 >> On 29 May 2016, at 20:28 , Garrett Cooper wrote: >>=20 >> Author: ngie >> Date: Sun May 29 20:28:01 2016 >> New Revision: 300973 >> URL: https://svnweb.freebsd.org/changeset/base/300973 >>=20 >> Log: >> Follow up to r300932 >>=20 >> In the event MK_INET6 !=3D no in userspace, but is disabled in the >> kernel, or if there aren't any IPv6 addresses configured in userspace >> (for lo0 and all physical interfaces), rpcbind would terminate >> immediately instead of silently failing on >>=20 >> Skip over the IPv6 block to its respective cleanup with freeifaddrs if >> creating the socket failed instead of terminating rpcbind immediately >=20 > Stupid question (without me looking at the code): what does it do in case= I have no IPv4 support in the kernel anymore (as I do on some machines)? The socket call only applied to IPv6. It intentionally sets the multicast ad= dress and leaks the socket, which causes coverity to note the leak as fd is l= ocal to the function. I'll definite try out this case as well tonight.. init_transport(..) (anothe= r function in rpcbind that uses rpc(3) under the covers) was not working und= er certain edge cases with some changes I had put up for CR. I feel like I wandered into another blackberry bramble patch with rpc(3). I h= ave some ideas for refactoring rpcbind and friends to ease maintenance that I= 'll work on after 11.0-RELEASE hits. Thanks! -Ngie=