From owner-svn-src-all@FreeBSD.ORG Tue Oct 21 12:10:31 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 36049106569C; Tue, 21 Oct 2008 12:10:31 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 265518FC20; Tue, 21 Oct 2008 12:10:31 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id m9LCAVm4098677; Tue, 21 Oct 2008 12:10:31 GMT (envelope-from des@svn.freebsd.org) Received: (from des@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id m9LCAVuu098676; Tue, 21 Oct 2008 12:10:31 GMT (envelope-from des@svn.freebsd.org) Message-Id: <200810211210.m9LCAVuu098676@svn.freebsd.org> From: Dag-Erling Smorgrav Date: Tue, 21 Oct 2008 12:10:31 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r184123 - head/lib/libarchive X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Oct 2008 12:10:31 -0000 Author: des Date: Tue Oct 21 12:10:30 2008 New Revision: 184123 URL: http://svn.freebsd.org/changeset/base/184123 Log: Move va_end() up Modified: head/lib/libarchive/archive_util.c Modified: head/lib/libarchive/archive_util.c ============================================================================== --- head/lib/libarchive/archive_util.c Tue Oct 21 11:58:26 2008 (r184122) +++ head/lib/libarchive/archive_util.c Tue Oct 21 12:10:30 2008 (r184123) @@ -168,6 +168,7 @@ archive_set_error(struct archive *a, int va_start(ap, fmt); archive_string_vsprintf(&(a->error_string), fmt, ap); + va_end(ap); if (error_number > 0) { archive_strcat(&(a->error_string), ": "); #ifdef HAVE_STRERROR_R @@ -184,7 +185,6 @@ archive_set_error(struct archive *a, int archive_strcat(&(a->error_string), errp); } a->error = a->error_string.s; - va_end(ap); } void