From owner-svn-src-all@FreeBSD.ORG Mon Nov 10 20:41:15 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B98C2B3F; Mon, 10 Nov 2014 20:41:15 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8F9A2954; Mon, 10 Nov 2014 20:41:15 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-70-85-31.nwrknj.fios.verizon.net [173.70.85.31]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 645ABB923; Mon, 10 Nov 2014 15:41:14 -0500 (EST) From: John Baldwin To: Dimitry Andric Subject: Re: svn commit: r273266 - in head: lib/libkvm sys/compat/freebsd32 sys/kern sys/sys Date: Mon, 10 Nov 2014 15:35:23 -0500 Message-ID: <3279406.bOBVrcribU@ralph.baldwin.cx> User-Agent: KMail/4.14.2 (FreeBSD/10.1-PRERELEASE; KDE/4.14.2; amd64; ; ) In-Reply-To: References: <201410181936.s9IJaCwu018930@svn.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 10 Nov 2014 15:41:14 -0500 (EST) Cc: "svn-src-head@freebsd.org" , Adrian Chadd , "src-committers@freebsd.org" , Luigi Rizzo , "svn-src-all@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Nov 2014 20:41:15 -0000 On Monday, November 10, 2014 09:13:08 PM Dimitry Andric wrote: > I noted something similar for kgdb, when compiled with gcc: > > cc1: warnings being treated as errors > /usr/src/gnu/usr.bin/gdb/kgdb/trgt_i386.c: In function > 'kgdb_trgt_fetch_tss': /usr/src/gnu/usr.bin/gdb/kgdb/trgt_i386.c:142: > warning: comparison is always false due to limited range of data type > > In gnu/usr.bin/gdb/kgdb/kgdb.h, there is: > > struct kthr { > struct kthr *next; > uintptr_t paddr; > uintptr_t kaddr; > uintptr_t kstack; > uintptr_t pcb; > int tid; > int pid; > u_char cpu; > }; > > The cpu field is assigned from td.td_oncpu (which is an int) in > kgdb_thr_add_procs(), so I think it should be safe to change it to an > int too: > > Index: gnu/usr.bin/gdb/kgdb/kgdb.h > =================================================================== > --- gnu/usr.bin/gdb/kgdb/kgdb.h (revision 274350) > +++ gnu/usr.bin/gdb/kgdb/kgdb.h (working copy) > @@ -41,7 +41,7 @@ > uintptr_t pcb; > int tid; > int pid; > - u_char cpu; > + int cpu; > }; > > extern struct kthr *curkthr; Yes, please commit. -- John Baldwin