Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 16 Nov 2019 15:47:24 +0100
From:      Tobias Kortkamp <tobik@freebsd.org>
To:        Christoph Moench-Tegeder <cmt@burggraben.net>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r517720 - in head/graphics/sane-backends: . files
Message-ID:  <20191116144724.GA13566@urd.tobik.me>
In-Reply-To: <20191116135856.GA2409@elch.exwg.net>
References:  <201911160605.xAG65s6X098900@repo.freebsd.org> <20191116135856.GA2409@elch.exwg.net>

next in thread | previous in thread | raw e-mail | index | archive | help

--EVF5PPMfhYS0aIcm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Nov 16, 2019 at 02:58:56PM +0100, Christoph Moench-Tegeder wrote:
> ## Tobias Kortkamp (tobik@FreeBSD.org):
>=20
> > Log:
> >   graphics/sane-backends: Update to 1.0.28
>=20
> This broke graphics/sane-frontends, and gscan2pdf by extension.
>=20
> > Deleted:
> >   head/graphics/sane-backends/files/patch-include__sane__sane.h
>=20
> And this is why (beyond that, sane-frontends now throws quite a racket
> during build because it relied on #include's in sane-backend's header
> files which were "cleaned up" here as well).

Hmm, sorry about that.

Fedora applies the following patch to sane-frontends for this which
I think we could apply to it too.

Not sure what you mean by racket though?  There are no new warnings
in sane-frontends beyond the SANE_CAP_ALWAYS_SETTABLE thing with
sane-backends-1.0.28 [0] than what was there already with
sane-backends-1.0.27 [1].  Maybe I'm missing something.

[0] https://people.freebsd.org/~tobik/logs/sane-frontends-1.0.14_10.log=20
[1] http://beefy6.nyi.freebsd.org/data/120amd64-default/517298/logs/sane-fr=
ontends-1.0.14_10.log

Index: graphics/sane-frontends/files/patch-src_gtkglue.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- graphics/sane-frontends/files/patch-src_gtkglue.c	(nonexistent)
+++ graphics/sane-frontends/files/patch-src_gtkglue.c	(working copy)
@@ -0,0 +1,29 @@
+commit ddd90b1502a263d03938b1e45a57684d576993ba
+Author: Nils Philippsen <nils@redhat.com>
+Date:   Fri Jul 31 16:25:58 2009 +0200
+
+    patch: sane-backends-1.0.20
+   =20
+    Squashed commit of the following:
+   =20
+    commit 0c84326fa37bb309481c4d2658ab6cb17c9f0e85
+    Author: Nils Philippsen <nils@redhat.com>
+    Date:   Fri Jul 31 16:18:59 2009 +0200
+   =20
+        use SANE_CAP_ALWAYS_SETTABLE only if available
+
+--- src/gtkglue.c.orig	2005-04-16 13:12:07 UTC
++++ src/gtkglue.c
+@@ -1476,8 +1476,12 @@ gsg_set_sensitivity (GSGDialog * dialog, int sensit=
ive
+ 	  || opt->type =3D=3D SANE_TYPE_GROUP || !dialog->element[i].widget)
+ 	continue;
+=20
++#ifdef SANE_CAP_ALWAYS_SETTABLE
+       if (!(opt->cap & SANE_CAP_ALWAYS_SETTABLE))
+ 	gtk_widget_set_sensitive (dialog->element[i].widget, sensitive);
++#else
++	gtk_widget_set_sensitive (dialog->element[i].widget, sensitive);
++#endif
+     }
+ }
+=20

Property changes on: graphics/sane-frontends/files/patch-src_gtkglue.c
___________________________________________________________________
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property

--EVF5PPMfhYS0aIcm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl3QC/lfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1
N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF
H2HhmQf+OjzjC03uP0AGMZJzJMCIVWR6jSVbBBXRB/zQ3wiuDp+qNhR/hLCrcE4I
KTzcGLfErFWnxb3EVOpKeiAlbrfteM5a+Ud94dT8EREWfLCIO7Ni+M68bSYnZ/yD
ErqVZ7CTqrFtiD6QtSHsy7ZRt98z3EGC2/h0+/u8lik5RMFgYQuPjxwd+adHXWzk
vb6NdWL1BDojfKWAHyk8b72yk91n0e/0uTm4KRnANVsAQ9G6oGaZDBg/FfUr/Vju
Oeriz21QXylDApoPcKAKh1fwrhURuq3YWb8ffxwRivtqfYM4tBe8ZneS+UGfxuu4
suDUAyE4BNzqV0bCjMGOBZPZ8BqGGA==
=UXp0
-----END PGP SIGNATURE-----

--EVF5PPMfhYS0aIcm--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191116144724.GA13566>