Date: Sun, 27 Nov 2016 13:34:37 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Willem Jan Withagen <wjw@digiware.nl>, "ports@freebsd.org" <ports@freebsd.org> Subject: Re: running make makesum for multiple github repos Message-ID: <2a5f6706-ec7b-097c-0879-d0e8e85b203b@FreeBSD.org> In-Reply-To: <e595a117-e8c3-5e2f-dce2-1ca21d41d70a@digiware.nl> References: <14fe8d55-2d90-d722-653e-ff2df119b408@digiware.nl> <c421545d-5803-c887-da68-ae6594e67c47@FreeBSD.org> <e595a117-e8c3-5e2f-dce2-1ca21d41d70a@digiware.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--UdCUwdLJ34RiOspB0iWi5OlTpl8s5hT8g
Content-Type: multipart/mixed; boundary="Ghu0ACGFGtuEApKMV5aeoitQuqlObNPIo";
protected-headers="v1"
From: Mathieu Arnold <mat@FreeBSD.org>
To: Willem Jan Withagen <wjw@digiware.nl>,
"ports@freebsd.org" <ports@freebsd.org>
Message-ID: <2a5f6706-ec7b-097c-0879-d0e8e85b203b@FreeBSD.org>
Subject: Re: running make makesum for multiple github repos
References: <14fe8d55-2d90-d722-653e-ff2df119b408@digiware.nl>
<c421545d-5803-c887-da68-ae6594e67c47@FreeBSD.org>
<e595a117-e8c3-5e2f-dce2-1ca21d41d70a@digiware.nl>
In-Reply-To: <e595a117-e8c3-5e2f-dce2-1ca21d41d70a@digiware.nl>
--Ghu0ACGFGtuEApKMV5aeoitQuqlObNPIo
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Le 27/11/2016 =C3=A0 12:57, Willem Jan Withagen a =C3=A9crit :
> On 26-11-2016 21:10, Mathieu Arnold wrote:
>> Le 25/11/2016 =C3=A0 12:46, Willem Jan Withagen a =C3=A9crit :
>>> Hi,
>>>
>>> I'm try in to make a port for Ceph, but it depens on a lot of github
>>> modules.
>> From having a quick look at the GH_TUPLE, it seems you have duplicate
>> tags, the fourth field. You seem to always put :ceph, but it *must* b=
e
>> unique.
>>
>> Also, you are using master at least twice, you must not use branch
>> names, you must put tags or commit hashes.
> Hi Mathieu,
>
> Your remarks pushed me in the right direction.
> I needed to fix two things:
> Fetching all the repos, and they needed to be IN the tree that is
> fetched with master.
>
> So indeed the fourth field (which is called group) needs to be
> different, then all the repos are fetched. Placing them in
> subdirectories of ${WRKSRC} is done by adding the path after a / after
> the group.
>
> IMHO a sort of an illogical last element of GH_TUPLE. And perhaps
> deserves a bit/lot more explaining in the handbook.
It is all documented in the USE_GITHUB section[1] of the Porter's
Handbook. The format of GH_TUPLE is described there too, and there are a
few examples, including one extended one describing what you are trying
to do.
The GH_TUPLE format is a bit strange, I agree, but the subdirectory
could not be put in another place because the third field (commit or
tag) can contain a / (there are a few examples in the tree), and the
path can contain a : (I stumbled upon one).
Also, GH_SUBDIR is optional, and it was a bad idea to put an optional
part in the middle of the string.
(And I'm not talking about the fact that GH_SUBDIR is newer than
GH_TUPLE, and that backward compatibility needed to be kept.)
> It now looks like:
> GH_TUPLE+=3D ceph:xxHash:v0.5.1-2-g1f40c65:xxHash/src/xxHash
> GH_TUPLE+=3D ceph:isa-l:v2.16.0:isal/src/isa-l
> GH_TUPLE+=3D ceph:lua:lua-5.3-ceph:lua/src/lua
> GH_TUPLE+=3D ceph:Beast:999e2fa:Beast/src/Beast
> GH_TUPLE+=3D boostorg:boost:boost-1.61.0-275-g1790aff:boost/src/bo=
ost
> GH_TUPLE+=3D ceph:dpdk:a38e5ec:dpd/src/dpd
1:
https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.=
html#makefile-master_sites-github
--=20
Mathieu Arnold
--Ghu0ACGFGtuEApKMV5aeoitQuqlObNPIo--
--UdCUwdLJ34RiOspB0iWi5OlTpl8s5hT8g
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQJ8BAEBCgBmBQJYOtLeXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85ITDMP/iX42ISG5r9gCoQgcDjnMVNx
teGPf56ANp3hZDT/lxjtwhD1zi/Xl4eip/McXTCvyU5m0G4/udwNkvW70Fp3CMQb
LctjZinhpkGvsiJ7LEapYyyZCfYWp9TmTC5ttkP/hQ1jcu8s59kBP0JSctZl1+Ab
n2I9xVtVH+v0MUNLKv2kCThBUQ6ajd82hK0Kmt1WZ6PtYbmEy4z8xRwIDECqhsHq
A6UtXF8MdnAeVZtPGHRcizORIPk/TPpvgcX0P/jsQCrKo5AxoVK+KKFxNJYmWstd
Pf055V9aDr0xNs/ZhT6U2SFkplRyyjD2n5AYaHixBuORqZi9OPl8U4JjkI2CkZXm
rj9MGvg1vMMOe9r5oXtmSK5s7GP53UwltXr/+I+lCtsY9q0Aipeci02QlqXOfqfZ
RxNJd8wIN6pXZIMuzBHEoDkpVc38jcrVLAYShKbp5kSyJNP30W8+36Tib6rKH8ZT
gZko1ZpZiG+y7Z1Mhs20bL6wqLQ6i29uVY/qSTW4oZalmF4AVyO2M0W5XJ7ExmYe
6Q7RgJltReqjxevYgZIlhFp9bghMGhOnjx1RNwDbHIquWek/ef+DRbfJ3BbsisFk
n4KgnPTAR2RBMFoi+Pc/ASPRSljVCmxwXIcvDe0TzMXwoynngle5O7QU8CmUh5sY
YykwRA6RKtuMnTV1gwqJ
=T8Q+
-----END PGP SIGNATURE-----
--UdCUwdLJ34RiOspB0iWi5OlTpl8s5hT8g--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2a5f6706-ec7b-097c-0879-d0e8e85b203b>