From nobody Wed Jan 31 16:21:15 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TQ6jV2KTzz58pcY; Wed, 31 Jan 2024 16:21:18 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TQ6jV1rBFz4Bp8; Wed, 31 Jan 2024 16:21:18 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706718078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KITL8JbYfjCEIjwKHZGt1Q73ihkOiPCjjnKnwdqNGRQ=; b=xATsIgqmKXzQA/OrO120ZRQKKlwLs5HJ8w8UtzY5Lkx5X3X/Ef63SAzwIyb2fIGh6L6JJ9 Fkw7XBBqWMnOawBWStBhcLdT2g1Et3DZgY3ABklCPjP+DF3pNpebCGwQSVhj0KIe/ptTtZ ISOqwdNbkqHUP1QitOR3O1gGAPqJUprfzL/Tq4vzgg9VDdykzB99FBtIz4F2/ZPr5XT23h CW3Ny2XAT7HY1PooqQ9BG+p5EKQfxM2hhwclFuPNjMmvz1yXrqyCcZn1skyft8AA93Eppm YGjWFvSibXSiI3WOj/MmDzBhfnW6Q45p5jevQq43pQOp3h//Wk4LDOK0d/o4Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706718078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KITL8JbYfjCEIjwKHZGt1Q73ihkOiPCjjnKnwdqNGRQ=; b=CGTVMvCHw2Z/Cr8YYQA7bApfOgAYr/PGLgcuPrFfsH8EDBT7YLEjp3jkhD5oX90EdX03L3 aStAFIDbTZgB0oFuY6Eue4ReeyM+cecQ66HDzuiCoIZNmrYX8/qZnQ/y02DNXIf+5uxMbB BWjCJVZ5UgsUnp5rWLOVavV9Qrn25A8cv0+R1ATn9ycXlrY06EuzbvipYsxtdk0/qRGTHU MO24g1Ka+B4f4guwUOkBQ8Zez6MF/ix0+OsYghWtYSqX39A3/dJZC72zywNDeshA0zvjAa viCwSVBfMldqSRzSOvSPJ++qaQfGWF7XWyZNB566FbJo9EkwT49rJk6w6rZCpA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706718078; a=rsa-sha256; cv=none; b=tUDJPfHnqDuWkUImqUk8Vbxss8r/84z3vI6S+mQbi2VLJNwJTbRUV8D6YY9s3eb6PXR478 9tBegD1EFTsVtYwBh1M8y7IhfsGgz294b6KcZRqZ2RFTf33+FItpyIhy/T+HAYhD3V09Jj z8cCjgkccZRhEONeGzI/CoHLgShwS3N64ecAeSEoobOdUl/521hPyBPyHumN6IKbhd20Bc PENo8+zfQOxj99KaLJNjGRJnCDW4WY4EbHGmoCX/dfnzxB8+zmMNcMvG4tYKchMpGOqLof kY+5fisOi/7bMxmKtk/GENawyYBJDZYfNFxP0T26E0w5Q/QzqKUfuTDoLuP3FQ== Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 0310B1D645; Wed, 31 Jan 2024 16:21:18 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 4C8116099; Wed, 31 Jan 2024 08:21:17 -0800 (PST) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id H5ZQENrgs56U; Wed, 31 Jan 2024 08:21:15 -0800 (PST) Message-ID: <7ac0bf41-0688-4303-9d37-fa2fff1eda1b@FreeBSD.org> DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com 74E126090 Date: Wed, 31 Jan 2024 08:21:15 -0800 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 9f0ce98efea9 - main - irc/rbot: Moved man to share/man Content-Language: en-US To: Moin Rahman Cc: ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202401291954.40TJsWBe042649@gitrepo.freebsd.org> <06e37dcd52f33a4fda060d86048e629f@FreeBSD.org> <7b83c2c7-5048-409c-a55f-666c10086d71@FreeBSD.org> From: Bryan Drewery Organization: FreeBSD In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/31/2024 7:33 AM, Moin Rahman wrote: > > >> On Jan 31, 2024, at 4:25 PM, Bryan Drewery wrote: >> >> On 1/31/2024 7:23 AM, Bryan Drewery wrote: >>> On 1/31/2024 7:09 AM, Moin Rahman wrote: >>>> >>>> >>>>> On Jan 31, 2024, at 3:51 PM, Bryan Drewery wrote: >>>>> >>>>> On 2024-01-29 11:54, Muhammad Moinur Rahman wrote: >>>>>> The branch main has been updated by bofh: >>>>>> URL: https://cgit.FreeBSD.org/ports/commit/?id=9f0ce98efea9ca39d4930569c7a072a9431793b2 >>>>>> commit 9f0ce98efea9ca39d4930569c7a072a9431793b2 >>>>>> Author: Muhammad Moinur Rahman >>>>>> AuthorDate: 2024-01-29 18:03:32 +0000 >>>>>> Commit: Muhammad Moinur Rahman >>>>>> CommitDate: 2024-01-29 19:54:13 +0000 >>>>>> irc/rbot: Moved man to share/man >>>>> >>>>> I think you should be testing these before committing. This one doesn't use GNU configure. >>>> What makes you think that my commits are not well tested? >>>> This was when I committed: >>>> https://pkg.bofh.network/data/132-default/2024-01-29_19h19m37s/logs/rbot-20160325_2,1.log >>>> >>>> This is now: >>>> https://pkg.bofh.network/data/132-default/2024-01-31_16h01m20s/logs/rbot-20160325_2,1.log >>>> >>>> GNU_CONFIGURE_MANPREFIX has nothing to do with GNU_CONFIGURE itself and it is mainly passed >>>> as a var to CONFIGURE_ARGS. >>> GNU_CONFIGURE_MANPREFIX absolutely only has to do with GNU_CONFIGURE. Check bsd.port.mk. >>> ~/git/ports/main/irc/rbot # make -V CONFIGURE_ARGS >>> --prefix=/usr/local >>> ~/git/ports/main/irc/rbot # make -V __LATE_CONFIGURE_ARGS >>> __LATE_CONFIGURE_ARGS only includes GNU_CONFIGURE_MANPREFIX if `./configure --help` shows a mandir. >>> Do you have output in either of those? >> >> or CONFIGURE_CMD? >> ~/git/ports/main/irc/rbot # make -V CONFIGURE_CMD >> ./configure >> >> The only way it could work for you is if that says "ruby setup.rb" which doesn't make sense since ruby.mk does not set that, it uses ruby-setup-configure target. >> >> This is required to build for me: >> >> diff --git irc/rbot/Makefile irc/rbot/Makefile >> index 06984ff5bcfc..0d9304566079 100644 >> --- irc/rbot/Makefile >> +++ irc/rbot/Makefile >> @@ -25,8 +25,7 @@ LIB_DEPENDS= libtokyocabinet.so:databases/tokyocabinet >> >> USES= cpe ruby:setup >> >> -GNU_CONFIGURE_MANPREFIX= ${PREFIX}/share >> -CONFIGURE_ARGS= --prefix=${PREFIX} >> +CONFIGURE_ARGS= --prefix=${PREFIX} --mandir=${PREFIX}/share/man >> NO_ARCH= yes >> >> USE_GITHUB= yes >> >>>> >>>>> ===> Building rbot-20160325_2,1 >>>>> pkg-static: Unable to access file /wrkdirs/usr/ports/irc/rbot/work/stage/usr/local/share/man/rbot.xml.gz:No such file or directory >>>>> *** Error code 1 >>>> This is not reproducible in latest ports tree at least. >>>> >>>>> >>>>>> Approved by: portmgr (blanket) >>>>>> --- >>>>>> irc/rbot/Makefile | 3 ++- >>>>>> irc/rbot/pkg-plist | 2 +- >>>>>> 2 files changed, 3 insertions(+), 2 deletions(-) >>>>>> diff --git a/irc/rbot/Makefile b/irc/rbot/Makefile >>>>>> index aca35f99db58..06984ff5bcfc 100644 >>>>>> --- a/irc/rbot/Makefile >>>>>> +++ b/irc/rbot/Makefile >>>>>> @@ -1,6 +1,6 @@ >>>>>> PORTNAME= rbot >>>>>> PORTVERSION= 20160325 >>>>>> -PORTREVISION= 1 >>>>>> +PORTREVISION= 2 >>>>>> PORTEPOCH= 1 >>>>>> CATEGORIES= irc ruby >>>>>> @@ -25,6 +25,7 @@ LIB_DEPENDS= libtokyocabinet.so:databases/tokyocabinet >>>>>> USES= cpe ruby:setup >>>>>> +GNU_CONFIGURE_MANPREFIX= ${PREFIX}/share >>>>>> CONFIGURE_ARGS= --prefix=${PREFIX} >>>>>> NO_ARCH= yes >>>>>> diff --git a/irc/rbot/pkg-plist b/irc/rbot/pkg-plist >>>>>> index e411686f8392..dfe970ca87da 100644 >>>>>> --- a/irc/rbot/pkg-plist >>>>>> +++ b/irc/rbot/pkg-plist >>>>>> @@ -42,7 +42,7 @@ bin/rbotdb >>>>>> %%RUBY_SITELIBDIR%%/rbot/registry/tc.rb >>>>>> %%RUBY_SITELIBDIR%%/rbot/rfc2812.rb >>>>>> %%RUBY_SITELIBDIR%%/rbot/timer.rb >>>>>> -man/rbot.xml.gz >>>>>> +share/man/rbot.xml.gz >>>>>> %%DATADIR%%/contrib/plugins/stats.rb >>>>>> %%DATADIR%%/contrib/plugins/vandale.rb >>>>>> %%DATADIR%%/filters/rss.rb >>>> >> >> -- >> Bryan Drewery > > At this point I really do not have the time to seek individual ports with this much details as I am doing all massive changes which are tested at least in my side with poudriere and which works. Yes there are cases where it regresses other ports which I am fixing too. > > If you think this port is useful to you change it as per your requirements. > This attitude sucks. If you are going to do mass updates you need to pay attention to bug reports and recognize that you don't understand what you think you do. I solved it for you. Thanks for wasting MY TIME. commit cbef135749e78bd37090778f798a3940ac0d0c1c Author: Muhammad Moinur Rahman Date: Mon Jan 22 19:17:34 2024 +0100 lang/ruby31: Sanitize MANPREFIX This changed ruby's internal mandir to share/man rather than man. Because no PORTREVISION bump was done my builds have the old ruby with the old mandir. The irc/rbot change _did nothing_. Your system must have a rebuilt ruby. I verified this by directly modifying /usr/local/lib/ruby/3.1/amd64-freebsd15/rbconfig.rb This is not some individual port problem. Apparently all ruby ports will be broken now until a PORTREVISION bump is done. The irc/rbot change should be reverted since it does nothing. I'll let you handle these and determine what else may be wrong elsewhere. -- Bryan Drewery