Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 9 Sep 2024 16:18:43 GMT
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: 32b36422168e - main - dns/bind9*: fix WITH_DEBUG build
Message-ID:  <202409091618.489GIhWK058658@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by glebius:

URL: https://cgit.FreeBSD.org/ports/commit/?id=32b36422168e8af0e6c082310ee81b9b2f86e012

commit 32b36422168e8af0e6c082310ee81b9b2f86e012
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2024-09-09 16:15:40 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2024-09-09 16:16:55 +0000

    dns/bind9*: fix WITH_DEBUG build
    
    The READLINE_CFLAGS="-L${LOCALBASE}/lib" env came with bind 9.18 with no
    explanation.  With 9.20 it actually breaks the developer build:
    
    cc: error: argument unused during compilation: '-L/usr/local/lib' [-Werror,-Wunused-command-line-argument]
    
    The --enable-symtable configure option is no longer supported by bind and
    just produces a warning.
    
    Reviewed by:            mat
    Differential Revision:  https://reviews.freebsd.org/D46540
---
 dns/bind9-devel/Makefile | 4 +---
 dns/bind920/Makefile     | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/dns/bind9-devel/Makefile b/dns/bind9-devel/Makefile
index 796ebfb360f4..bb38b56dd3b9 100644
--- a/dns/bind9-devel/Makefile
+++ b/dns/bind9-devel/Makefile
@@ -60,7 +60,6 @@ CONFIGURE_ARGS=	--localstatedir=/var \
 		--with-openssl=${OPENSSLBASE} \
 		--enable-dnsrps \
 		--with-readline=libedit
-CONFIGURE_ENV=	READLINE_CFLAGS="-L${LOCALBASE}/lib"
 ETCDIR=		${PREFIX}/etc/namedb
 
 # FIXME: figure out why build fails if enabled
@@ -171,8 +170,7 @@ TCP_FASTOPEN_CONFIGURE_ENABLE=	tcp-fastopen
 .include <bsd.port.options.mk>
 
 .if defined(WITH_DEBUG)
-CONFIGURE_ARGS+=	--enable-developer \
-			--enable-symtable
+CONFIGURE_ARGS+=	--enable-developer
 USES+=			perl5
 USE_PERL5=		build
 BUILD_DEPENDS+=		cmocka>0:sysutils/cmocka
diff --git a/dns/bind920/Makefile b/dns/bind920/Makefile
index 82f5a5993f86..3d6fd53fad9b 100644
--- a/dns/bind920/Makefile
+++ b/dns/bind920/Makefile
@@ -59,7 +59,6 @@ CONFIGURE_ARGS=	--localstatedir=/var \
 		--with-openssl=${OPENSSLBASE} \
 		--enable-dnsrps \
 		--with-readline=libedit
-CONFIGURE_ENV=	READLINE_CFLAGS="-L${LOCALBASE}/lib"
 ETCDIR=		${PREFIX}/etc/namedb
 
 # FIXME: figure out why build fails if enabled
@@ -168,8 +167,7 @@ TCP_FASTOPEN_CONFIGURE_ENABLE=	tcp-fastopen
 .include <bsd.port.options.mk>
 
 .if defined(WITH_DEBUG)
-CONFIGURE_ARGS+=	--enable-developer \
-			--enable-symtable
+CONFIGURE_ARGS+=	--enable-developer
 USES+=			perl5
 USE_PERL5=		build
 BUILD_DEPENDS+=		cmocka>0:sysutils/cmocka



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202409091618.489GIhWK058658>