From owner-svn-src-head@freebsd.org Tue May 15 16:18:52 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34CE8EE57C2; Tue, 15 May 2018 16:18:52 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pf0-x232.google.com (mail-pf0-x232.google.com [IPv6:2607:f8b0:400e:c00::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id ABB5672A5D; Tue, 15 May 2018 16:18:51 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pf0-x232.google.com with SMTP id q22-v6so286115pff.11; Tue, 15 May 2018 09:18:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G7U86/reqWVMFcOBEetvLaXT/sZYDuu0nwx45Z+ca6A=; b=dWt8ExNDne4j72mNhTabVqi5n6nU3/nDsJ43P7Re4wMkjHlt379AyULjrOlLfeGwcM oemW0eRRodHEh+nDMOYD0N/2jj6DdBu2SVnwaPruKjEIQnTbu6ZIWtrePnlfu7vqepUQ bP4rf27KbECyN1Chi6wlUsQVxusFSsFI4YCyncZo4FZp4179FGHJxngnXLTPWk3MXmry YcKHEIFjf5G1zCwsgugrRp9+Tx7jpWVot+MQhWOCF+7Xej53oiy0qOi2m9B5QHdry0Sd w9Cp7pT3WYuKVCb1VPFIATKY/uLWJ+wWqaBjwRGf7ayEcB7mshtMfpSNk2HLTiCa8Sz6 gbKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=G7U86/reqWVMFcOBEetvLaXT/sZYDuu0nwx45Z+ca6A=; b=WiuN0+kjsO6vw30lRScZ5xWuirGWhUYReagk6bzoUkMJP5KRa1zPuVjiulZXRfC33e i9QqILxuSJuUJ6ydYEJxpG/1SqyL1z8sTXBqx3I0ZwzsLZmlBpJZ1rqelJ0fvgj4H/mH id1Bux+P/SlaBu+KE/7APKbRvuWnniq8NAL5DFkbOBkCVfyiGHz2fC2/ky186xROU7nW tZphO9IgqtghbF6BuAiytnbHNsk3G/lTyS4mNbLEkCDDkOKwJ4Kn1N8wydE+cXxCQSlw tORVdpOLOTjf8s9zzRXT/cCfrckXyZHJ5VNsWG7uusFyZZNMahAURchkcOGxVEYRa6ft qSvQ== X-Gm-Message-State: ALKqPwe9fHWjX0c26WHR+Z3hA8CkU3a2lTyroWgg6uGoA+zOgJWsceES fH6sL3fD8/0rPEw+n01Xy+Y7XA== X-Google-Smtp-Source: AB8JxZoltKQPu7w1j8wtIW4GRuQU08bZGDYsyKijWPmSgesh/+E6iHaSQTlKHrejly88Ivxbb6AtkQ== X-Received: by 2002:a65:4443:: with SMTP id e3-v6mr12923745pgq.348.1526401130318; Tue, 15 May 2018 09:18:50 -0700 (PDT) Received: from raichu (toroon0560w-lp140-04-70-29-84-206.dsl.bell.ca. [70.29.84.206]) by smtp.gmail.com with ESMTPSA id 184-v6sm579102pfg.89.2018.05.15.09.18.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 May 2018 09:18:49 -0700 (PDT) Sender: Mark Johnston Date: Tue, 15 May 2018 12:18:43 -0400 From: Mark Johnston To: Matt Macy Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333345 - head/sys/dev/e1000 Message-ID: <20180515161843.GA63058@raichu> References: <201805080139.w481djMX062724@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201805080139.w481djMX062724@repo.freebsd.org> User-Agent: Mutt/1.9.5 (2018-04-13) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 16:18:52 -0000 On Tue, May 08, 2018 at 01:39:45AM +0000, Matt Macy wrote: > Author: mmacy > Date: Tue May 8 01:39:45 2018 > New Revision: 333345 > URL: https://svnweb.freebsd.org/changeset/base/333345 > > Log: > Sleep rather than spin in e1000 when doing long running config operations. > > With r333218 it is now possible for drivers to use an sx lock and thus sleep while > waiting on long running operations rather than DELAY(). > > Reported by: gallatin > Reviewed by: sbruno > Approved by: sbruno > MFC after: 1 month > Sponsored by: Limelight Networks > Differential Revision: https://reviews.freebsd.org/D14984 This commit causes igb to fail to attach to one of the ports on an I210: igb0@pci0:5:0:0: class=0x020000 card=0x153315d9 chip=0x15338086 rev=0x03 hdr=0x00 vendor = 'Intel Corporation' device = 'I210 Gigabit Network Connection' class = network subclass = ethernet igb1@pci0:6:0:0: class=0x020000 card=0x153315d9 chip=0x15338086 rev=0x03 hdr=0x00 vendor = 'Intel Corporation' device = 'I210 Gigabit Network Connection' class = network subclass = ethernet In the dmesg I see: igb0: port 0xd000-0xd01f mem 0xf8300000-0xf837ffff,0xf8380000-0xf8383fff irq 18 at device 0.0 numa-domain 0 on pci6 igb0: attach_pre capping queues at 4 igb0: Setup of Shared code failed, error -2 igb0: IFDI_ATTACH_PRE failed 6 device_attach: igb0 attach returned 6 pcib7: irq 19 at device 28.3 numa-domain 0 on pci1 pci7: numa-domain 0 on pcib7 igb0: port 0xc000-0xc01f mem 0xf8200000-0xf827ffff,0xf8280000-0xf8283fff irq 19 at device 0.0 numa-domain 0 on pci7 igb0: attach_pre capping queues at 4 igb0: using 1024 tx descriptors and 1024 rx descriptors igb0: msix_init qsets capped at 4 igb0: pxm cpus: 8 queue msgs: 4 admincnt: 1 igb0: using 4 rx queues 4 tx queues igb0: Using MSIX interrupts with 5 vectors igb0: allocated for 4 tx_queues igb0: allocated for 4 rx_queues