From owner-svn-ports-head@FreeBSD.ORG  Thu Jan  9 11:12:48 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 80CD9F98;
 Thu,  9 Jan 2014 11:12:48 +0000 (UTC)
Received: from mail-we0-x22f.google.com (mail-we0-x22f.google.com
 [IPv6:2a00:1450:400c:c03::22f])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id A0ECE18AC;
 Thu,  9 Jan 2014 11:12:47 +0000 (UTC)
Received: by mail-we0-f175.google.com with SMTP id w62so2629079wes.34
 for <multiple recipients>; Thu, 09 Jan 2014 03:12:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=OuG+Rr+x9cmQC7jNMI/HMxisvL3F5vIaFt0vwZns2lA=;
 b=BCNqQVSaGSzfdvKwJjBrkV3vXFRb71qtg1Sj9Z7PgtgwpUlhcx9t2zuqK2Na1+ivEv
 mIr5byueaBfqR449IjVIWPo35L8hCe6AUxyred4BHcjxijwTpUQABKZ19W/7dBXqnJ79
 wID91B+FPgO9G8Q/GN0Cgu86tKI5py3QGu5lNyHm3RI/5wUX+6tqR7dRiR02m+YuC2Kb
 1uGCy5J8XNjYRAKdsczuSboHJL7+svvMW9By674aMFxAa4ERu7gP5PrUyVMtHaRAZFi/
 M5huwQ0hC5BGyl2yKDLuQ6L7NEQ0L2/cQuTKKSvZM/jhrQO+Ni8sFLzHsKVLWhczywI1
 He1w==
MIME-Version: 1.0
X-Received: by 10.180.77.49 with SMTP id p17mr25366501wiw.30.1389265966132;
 Thu, 09 Jan 2014 03:12:46 -0800 (PST)
Sender: antoine.brodin.freebsd@gmail.com
Received: by 10.194.33.37 with HTTP; Thu, 9 Jan 2014 03:12:46 -0800 (PST)
In-Reply-To: <20140109110311.GA46469@FreeBSD.org>
References: <201312311227.rBVCRwfe081248@svn.freebsd.org>
 <20140109110311.GA46469@FreeBSD.org>
Date: Thu, 9 Jan 2014 12:12:46 +0100
X-Google-Sender-Auth: LSXHR3KNFBDkM82aA5B-0qgL0UU
Message-ID: <CAALwa8meEZ6GYMpMb1NvQCNk3k2Cp7=7rhn7g7xsftHW3Z82SA@mail.gmail.com>
Subject: Re: svn commit: r338284 - head/comms/gnocky
From: Antoine Brodin <antoine@FreeBSD.org>
To: Alexey Dokuchaev <danfe@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jan 2014 11:12:48 -0000

On Thu, Jan 9, 2014 at 12:03 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Tue, Dec 31, 2013 at 12:27:58PM +0000, Antoine Brodin wrote:
>> New Revision: 338284
>> URL: http://svnweb.freebsd.org/changeset/ports/338284
>>
>> -.if ${PORT_OPTIONS:MNLS}
>> -USES+=               gettext
>> -PLIST_SUB+=  NLS=""
>> -.else
>> -CONFIGURE_ARGS+=     --disable-nls
>> -PLIST_SUB+=  NLS="@comment "
>> -.endif
>> +OPTIONS_SUB= yes
>> +NLS_USES=    gettext
>> +NLS_CONFIGURE_ENABLE=        nls
>
> Why not just NLS_CONFIGURE_OFF= --disable-nls?  It looks like NLS support is
> on by default, and NLS_CONFIGURE_OFF saves passing explicit --enable-nls to
> the args (thus making them shorter).


Hello,

NLS_CONFIGURE_ENABLE=nls is 7 characters less than
NLS_CONFIGURE_OFF=--disable-nls
So it makes the Makefile shorter.

Cheers,

Antoine