From owner-cvs-all Mon Sep 10 16: 6:55 2001 Delivered-To: cvs-all@freebsd.org Received: from tao.org.uk (genius.tao.org.uk [212.135.162.51]) by hub.freebsd.org (Postfix) with ESMTP id D295137B405; Mon, 10 Sep 2001 16:06:49 -0700 (PDT) Received: by tao.org.uk (Postfix, from userid 100) id D50B4453; Tue, 11 Sep 2001 00:06:47 +0100 (BST) Date: Tue, 11 Sep 2001 00:06:47 +0100 From: Josef Karthauser To: Peter Wemm Cc: Josef Karthauser , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: CVSROOT cfg.pm commit_prep.pl Message-ID: <20010911000647.D2236@tao.org.uk> References: <20010909233407.A846@tao.org.uk> <20010910010823.75A15390B@overcee.netplex.com.au> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="eheScQNz3K90DVRs" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010910010823.75A15390B@overcee.netplex.com.au>; from peter@wemm.org on Sun, Sep 09, 2001 at 06:08:23PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --eheScQNz3K90DVRs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 09, 2001 at 06:08:23PM -0700, Peter Wemm wrote: > >=20 > > Hmm, looks like there's no clean way to do this. For a local commit > > the local file (in the committers's working directory) is modified. > > Unfortunately this all happens before the commit message is entered. > > If they abort the commit at this time the file will have already > > had it's $Id$ unexpanded. :( Is this acceptable? >=20 > Yes, but if it is done after the check for each directory, then we should > be pretty sure that a regression didn't happen. Note that a empty $tag$ > is accepted so the second time around it would still be allowed. I've committed a newer version of this. Would you mind taking a look? Feel free to switch it on in the cfg.pm file if you're happy with it. Joe --eheScQNz3K90DVRs Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iEYEARECAAYFAjudR4cACgkQXVIcjOaxUBa3kgCg2YZNkvjenLnVYUnxTcwtTlQO Ws4An0cnP5Nljv5+yOQzQHDhiKdhSysB =rphg -----END PGP SIGNATURE----- --eheScQNz3K90DVRs-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message