From owner-freebsd-current@FreeBSD.ORG  Mon Nov 15 13:04:03 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7212D16A4CE; Mon, 15 Nov 2004 13:04:03 +0000 (GMT)
Received: from n33.kp.t-systems-sfr.com (n33.kp.t-systems-sfr.com
	[129.247.16.33])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2B81D43D1D; Mon, 15 Nov 2004 13:04:02 +0000 (GMT)
	(envelope-from harti@freebsd.org)
Received: from n81.sp.op.dlr.de (n81g.sp.op.dlr.de [129.247.163.1])
	iAFD3nU371998;	Mon, 15 Nov 2004 14:03:49 +0100
Received: from zeus.nt.op.dlr.de (zeus.nt.op.dlr.de [129.247.173.3])
	iAFD3nI346870;	Mon, 15 Nov 2004 14:03:49 +0100
Received: from beagle.kn.op.dlr.de (opkndnwsbsd178 [129.247.173.178])
	by zeus.nt.op.dlr.de (8.11.7+Sun/8.9.1) with ESMTP id iAFD4Ou05744;
	Mon, 15 Nov 2004 14:04:24 +0100 (MET)
Date: Mon, 15 Nov 2004 14:10:42 +0100 (CET)
From: Harti Brandt <harti@freebsd.org>
X-X-Sender: brandt@beagle.kn.op.dlr.de
To: Alexander Leidinger <Alexander@Leidinger.net>
In-Reply-To: <1100518191.4198932fc1dd4@netchild.homeip.net>
Message-ID: <20041115140821.A51863@beagle.kn.op.dlr.de>
References: <6857.1100271323@critter.freebsd.dk>
	<20041112160137.X42945@beagle.kn.op.dlr.de>
	<20041112171024.P42945@beagle.kn.op.dlr.de>
	<20041115091059.L51863@beagle.kn.op.dlr.de>
	<1100518191.4198932fc1dd4@netchild.homeip.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Poul-Henning Kamp <phk@phk.freebsd.dk>
cc: current@freebsd.org
Subject: Re: [TEST] make -j patch [take 2]
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Harti Brandt <harti@freebsd.org>
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Nov 2004 13:04:03 -0000

On Mon, 15 Nov 2004, Alexander Leidinger wrote:

AL>Zitat von Harti Brandt <harti@freebsd.org>:
AL>
AL>[knu CCed because he should know how portupgrade operates :-)]
AL>
AL>> Unless you reset MAKEFLAGS along the call path to the portupgrade's make
AL>> they'll see the -j, because the top-level make will stuff the -j into
AL>> MAKEFLAGS and that is probably inherited through portupgrade.
AL>
AL>I don't know how ruby handles exec()ing of external programs, but unless
AL>it inherits the environment by default, portupgrade doesn't seems to
AL>inherit MAKEFLAGS ("grep MAKEFLAGS /usr/local/lib/ruby/site_ruby/1.8/*
AL>/usr/local/sbin/port*" shows no hits).
AL>
AL>So if portupgrade inherits MAKEFLAGS somehow, phk's patch shouldn't
AL>cause unexpected harm in this szenario, if portupgrade doesn't inherit
AL>MAKEFLAGS, his patch violates POLA in this case.

At least portinstall doesn't touch MAKEFLAGS: insert something like
FOO!=echo -- ${MAKEFLAGS} >/tmp/A
into a port's makefile and call portinstall for than port:

MAKEFLAGS=-j2 portinstall ...

Would be strange if portupgrade would be different from portinstall. So 
nothing is broken that wasn't already.

harti