From owner-cvs-src@FreeBSD.ORG Tue Nov 30 17:49:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7048416A4CE; Tue, 30 Nov 2004 17:49:36 +0000 (GMT) Received: from ylpvm43.prodigy.net (ylpvm43-ext.prodigy.net [207.115.57.74]) by mx1.FreeBSD.org (Postfix) with ESMTP id 156CC43D5D; Tue, 30 Nov 2004 17:49:36 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222])iAUHndp8029901; Tue, 30 Nov 2004 12:49:39 -0500 Message-ID: <41ACB2A3.1010107@root.org> Date: Tue, 30 Nov 2004 09:49:23 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.3 (X11/20040901) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <200411232226.iANMQioc077290@repoman.freebsd.org> <20041130173902.GA56431@darkness.comp.waw.pl> In-Reply-To: <20041130173902.GA56431@darkness.comp.waw.pl> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: John Baldwin Subject: Re: cvs commit: src/sys/dev/acpica acpi_pci_link.c acpi_pcib.c acpi_pcib_acpi.c acpi_pcib_pci.c acpi_pcibvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2004 17:49:36 -0000 Pawel Jakub Dawidek wrote: > On Tue, Nov 23, 2004 at 10:26:44PM +0000, John Baldwin wrote: > +> jhb 2004-11-23 22:26:44 UTC > +> > +> FreeBSD src repository > +> > +> Modified files: > +> sys/dev/acpica acpi_pci_link.c acpi_pcib.c > +> acpi_pcib_acpi.c acpi_pcib_pci.c > +> acpi_pcibvar.h > +> Log: > +> Rework the ACPI PCI link code. > [...] > > Is this related to: > > FreeBSD 6.0-CURRENT #14: Tue Nov 30 18:17:51 CET 1999 > root@slayer.hell.invalid:/usr/obj/usr/src/HEAD/src/sys/LCF > Timecounter "i8254" frequency 1193182 Hz quality 0 > CPU: Intel(R) XEON(TM) CPU 1.80GHz (1799.76-MHz 686-class CPU) > Origin = "GenuineIntel" Id = 0xf24 Stepping = 4 > Features=0x3febfbff > Hyperthreading: 2 logical CPUs > real memory = 1073741824 (1024 MB) > avail memory = 1046126592 (997 MB) > ACPI APIC Table: > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > cpu0 (BSP): APIC ID: 0 > cpu1 (AP): APIC ID: 1 > cpu2 (AP): APIC ID: 6 > cpu3 (AP): APIC ID: 7 > MADT: Forcing active-low polarity and level trigger for SCI > ioapic0 irqs 0-15 on motherboard > ioapic1 irqs 16-31 on motherboard > npx0: [FAST] > npx0: on motherboard > npx0: INT 16 interface > acpi0: on motherboard > acpi0: Power Button (fixed) > can't fetch resources for \_SB_.LN1_ - AE_AML_INVALID_RESOURCE_TYPE > acpi_ec0: port 0xca7,0xca6 on acpi0 > Timecounter "ACPI-safe" frequency 3579545 Hz quality 1000 > acpi_timer0: <32-bit timer at 3.579545MHz> port 0x508-0x50b on acpi0 > cpu0: on acpi0 > cpu1: on acpi0 > cpu2: on acpi0 > cpu3: on acpi0 > acpi_button0: on acpi0 > pci_link0: on acpi0 > device_attach: pci_link0 attach returned 6 > pci_link1: irq 16 on acpi0 > panic: _sx_xlock (ACPI PCI link): xlock already held @ /usr/src/HEAD/src/sys/modules/acpi/acpi/../../../dev/acpica/acpi_pci_link.c:297 > cpuid = 0 > KDB: enter: panic > [thread pid 0 tid 0 ] > Stopped at kdb_enter+0x2c: leave > This is a fake panic I think. In any case, there is no need to lock in attach since the the boot code is single-threaded. I committed this change. There is another error above for LN1_ that should be examined separately. -Nate