From owner-freebsd-hackers@FreeBSD.ORG  Fri May  1 17:58:04 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3B412106564A
	for <freebsd-hackers@freebsd.org>; Fri,  1 May 2009 17:58:04 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outK.internet-mail-service.net (outk.internet-mail-service.net
	[216.240.47.234])
	by mx1.freebsd.org (Postfix) with ESMTP id 1D0DF8FC15
	for <freebsd-hackers@freebsd.org>; Fri,  1 May 2009 17:58:03 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from idiom.com (mx0.idiom.com [216.240.32.160])
	by out.internet-mail-service.net (Postfix) with ESMTP id 3EB15E3FC0;
	Fri,  1 May 2009 10:58:04 -0700 (PDT)
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38])
	by idiom.com (Postfix) with ESMTP id 4BF7C2D60D0;
	Fri,  1 May 2009 10:58:03 -0700 (PDT)
Message-ID: <49FB382B.6030406@elischer.org>
Date: Fri, 01 May 2009 10:58:03 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.21 (Macintosh/20090302)
MIME-Version: 1.0
To: "M. Warner Losh" <imp@bsdimp.com>
References: <49F4070C.2000108@gmx.de>	<20090501112239.GA23199@alchemy.franken.de>	<49FADEF3.5010106@gmx.de>
	<20090501.082020.698246310.imp@bsdimp.com>
In-Reply-To: <20090501.082020.698246310.imp@bsdimp.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: sobomax@freebsd.org, freebsd-hackers@freebsd.org, rdivacky@freebsd.org,
	ed@freebsd.org, marius@alchemy.franken.de, christoph.mallon@gmx.de
Subject: Re: C99: Suggestions for style(9)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 May 2009 17:58:04 -0000

M. Warner Losh wrote:

[...]
(about return ();)

> 
> It has been an example used for the past 15 years at least as to why
> to do this...  I don't know how many people have actually used the
> ability to do this in code.

I have done so..

> 
> : Also I consider this as gross abuse: Macro names shall be in all 
> : uppercase, so it is clear that there is a macro at work. Therefore 
> : "return" is not a candidate. So this would violate yet another rule in 
> : style(9) (the original return already violates the no-redundant 
> : parentheses rule).
> : Also I would not mention __func__: there were objections against using 
> : it in the past (though I, logically, prefer its use).
> 
> It is a debugging aid, but one of dubious value for a far more
> fundamental reason:
> 
> 	    return;
> 
> will break any macro.
> 
> Warner
> _______________________________________________
> freebsd-hackers@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"