Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 8 Mar 2010 09:21:34 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Warner Losh <imp@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r204850 - head/sys/kern
Message-ID:  <201003080921.34274.jhb@freebsd.org>
In-Reply-To: <201003072237.o27MbZnh088286@svn.freebsd.org>
References:  <201003072237.o27MbZnh088286@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 07 March 2010 5:37:35 pm Warner Losh wrote:
> Author: imp
> Date: Sun Mar  7 22:37:35 2010
> New Revision: 204850
> URL: http://svn.freebsd.org/changeset/base/204850
> 
> Log:
>   Bump up the firmware_table from 30 to 50.  bwn needs more than 30, it
>   seems.

Are you sure?  The error report I saw was from having firmwares for both 
bwi(4) and bwn(4) loaded.  Both of them use a lot of firmware images, but I 
don't think either one in isolation uses more than 30.

I really think that FIRMWARE_MAX should at the least become a loader tunable
and have the array malloc'd either on-demand or via a SYSINIT().

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003080921.34274.jhb>