From nobody Sun Sep 21 23:00:42 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cVMCz4KLkz687GP; Sun, 21 Sep 2025 23:00:47 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cVMCz3nsCz3rJC; Sun, 21 Sep 2025 23:00:47 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758495647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MjyrDH/EMziLBHeQ3tceZDwIiA4ZndGBrxyTbEhFTKA=; b=luber+Yo/GPn8E7AQPn3NaAy5gmyJiEhkecUwF+BLsMaLjW02f7R6xs7dnebsCFvWZrdYL qudcGg+vn4OLMDekV5MsGITlEB6bjuBI3rA2AUFd58t1fRYFaNDGgNWTYINjQNr2oozSCw UHXpmLg/6HACDF/DiQ7FkspspH8awMOzxVohof9lU/CpASL4ynigAEKOLOI54PJewaRCp0 /xlMDU0AL0D6TSnHo89SMmft7E/7gtmppif/iGVprF8wb/5bBulpL8gMnFmLkReelABRNU ZPgxYG2Ejk5/BNmCPNO5wDr8JpMDUG2jjGrLA/BmdJ0dpEKkCmz5At0AUShN1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758495647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MjyrDH/EMziLBHeQ3tceZDwIiA4ZndGBrxyTbEhFTKA=; b=Dzmu05/QOTcAAdMyPkGaIdqk8zyRlgANob8y/h46vgeJZNWsBCbLEHKEEpxxFcMZljxHEb uDkFDuwpZGndMyja2c1+Nv4tuGvNjlGAkmDH/urkO+DxASnKxSk6qMS2H0BPFuJuFOmjVf +K7c9mEd0N0rj0Hy0r21WimG+1VKSbBUhvYHlniRW1POkDqMfdCQ6LwyqKDtNVS+Yth+9Q +6Wm0+A7QhO8H/qC1d3PIrWQoa/sfXcXMrai6A/32/hSanFe5j+dY9PUcaThIPgU4N2GH1 sDiH0+a75Zz8MALalFtuwBHpnsdccNABM9C55DR+kjMGw7aR/CWJnWUC4Ljtsg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758495647; a=rsa-sha256; cv=none; b=nyCRbhthwo873nzQ4VqeALSMUFFGzQRABr2/Lh8qJheFEnDwHFDuPivcX4lyUoQr6NlK8a VuHeccVJt6jGbtkOETht9UNXLMomxlERikeXC3pMeDOFe9rDtTRbzr2hlNbzzFdetFYpdP i65MkJOUEnW5HcZVP9cu6+GwZapWpvdz5l/qMoSaIRgibX0MfZg8I2HfaAJeb9VpIy9fEu U5KieaksbCUF6ww2kiIwCXgdNQx9krYGMQVWlr7RxMiN+r3otrXthJjHeZl3QXHZT0BUb3 20dzSD2nfkjS0IgeMNva70BChLeJcKuBO8c58VtXl97Y0f8/+B2oRrTQsWrHbA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cVMCy49ZKzHyk; Sun, 21 Sep 2025 23:00:46 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Sun, 21 Sep 2025 16:00:42 -0700 From: Gleb Smirnoff To: Guido Falsi Cc: "Herbert J. Skuhra" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 31ec8b6407fd - main - sys/netinet6: Implement RFC 7217 Message-ID: References: <202509201231.58KCVqBC047480@gitrepo.freebsd.org> <874iswhip4.wl-herbert@gojira.at> <07503de1-785e-4e4d-b4e4-0524aeb064e1@FreeBSD.org> <87jz1sc9fr.wl-herbert@gojira.at> <31da7dd5-ae67-4fb4-aa47-81e57f460c9d@FreeBSD.org> <909b3e33-0639-4abc-915f-073cd0f304da@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <909b3e33-0639-4abc-915f-073cd0f304da@FreeBSD.org> On Sun, Sep 21, 2025 at 09:17:15PM +0200, Guido Falsi wrote: G> > Is struct nd_ifinfo something that is used as argument to ioctl(2)? G> > If so, then adding counter_u64_t into it is not correct. G> > G> > I would suggest to not revert the change as a whole, but remove the G> > counter only and bring struct nd_ifinfo back to original. The counter G> > should probably go into struct in6_ifextra that is pointed by G> > if->if_afdata[AF_INET6]. G> G> Thanks for the feedback and suggestion! G> G> You are definitely right! I'm in the process to create a review for such a G> change shortly, I'll post it as soon as I'm able to have the code tested. As long as Herbert confirms that the patch fixes the issue for him, please consider the change as approved by an src committer and please push it. We want to enter the stabweek that starts tomorrow without a ABI breakage. -- Gleb Smirnoff