From owner-cvs-src-old@FreeBSD.ORG Thu Nov 6 13:26:07 2008 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D50251065764 for ; Thu, 6 Nov 2008 13:26:06 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C97788FC13 for ; Thu, 6 Nov 2008 13:26:06 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mA6DQ6HZ056470 for ; Thu, 6 Nov 2008 13:26:06 GMT (envelope-from bz@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mA6DQ6gi056469 for cvs-src-old@freebsd.org; Thu, 6 Nov 2008 13:26:06 GMT (envelope-from bz@repoman.freebsd.org) Message-Id: <200811061326.mA6DQ6gi056469@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to bz@repoman.freebsd.org using -f From: "Bjoern A. Zeeb" Date: Thu, 6 Nov 2008 13:25:59 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet tcp_input.c tcp_subr.c tcp_var.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2008 13:26:08 -0000 bz 2008-11-06 13:25:59 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_subr.c tcp_var.h Log: SVN rev 184722 on 2008-11-06 13:25:59Z by bz Fix a bug introduced with r182851 splitting tcp_mss() into tcp_mss() and tcp_mss_update() so that tcp_mtudisc() could re-use the same code. Move the TSO logic back to tcp_mss() and out of tcp_mss_update(). We tried to avoid that initially but if were are called from tcp_output() with EMSGSIZE, we cleared the TSO flag on the tcpcb there, called into tcp_mtudisc() and tcp_mss_update() which then would reenable TSO on the tcpcb based on TSO capabilities of the interface as learnt in tcp_maxmtu/6(). So if TSO was enabled on the (possibly new) outgoing interface it was turned back on, which lead to an endless loop between tcp_output() and tcp_mtudisc() until we overflew the stack. Reported by: kmacy MFC after: 2 months (along with r182851) Revision Changes Path 1.389 +10 -9 src/sys/netinet/tcp_input.c 1.321 +1 -1 src/sys/netinet/tcp_subr.c 1.165 +1 -1 src/sys/netinet/tcp_var.h