From owner-cvs-all@FreeBSD.ORG Mon Jul 23 14:52:22 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 710A816A418; Mon, 23 Jul 2007 14:52:22 +0000 (UTC) (envelope-from attilio@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6673413C467; Mon, 23 Jul 2007 14:52:22 +0000 (UTC) (envelope-from attilio@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l6NEqMZ4074555; Mon, 23 Jul 2007 14:52:22 GMT (envelope-from attilio@repoman.freebsd.org) Received: (from attilio@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l6NEqMot074554; Mon, 23 Jul 2007 14:52:22 GMT (envelope-from attilio) Message-Id: <200707231452.l6NEqMot074554@repoman.freebsd.org> From: Attilio Rao Date: Mon, 23 Jul 2007 14:52:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_kse.c kern_thread.c src/sys/sys proc.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2007 14:52:22 -0000 attilio 2007-07-23 14:52:22 UTC FreeBSD src repository Modified files: sys/kern kern_kse.c kern_thread.c sys/sys proc.h Log: Actually, KSE kernel bits locking is broken and can lead likely to dangerous races. Fix this problems adding correct locking for the members of 'struct kse_upcall' and other struct proc/struct thread related members. For the moment, just leave ku_mflag and ku_flags "lazy" locked. While here, cleanup the code removing the function kse_GC() (unused), and merging upcall_link(), upcall_unlink(), upcall_stash() in their respective callers (static functions, very short and only called in one place). Reported by: pav Tested by: pav (on some pointyhat cluster nodes) Approved by: jeff Approved by: re Sponsorized by: NGX Italy (http://www.ngx.it) Revision Changes Path 1.232 +69 -82 src/sys/kern/kern_kse.c 1.251 +2 -0 src/sys/kern/kern_thread.c 1.488 +0 -1 src/sys/sys/proc.h