Date: Sat, 28 Jan 2006 16:38:28 +0000 (UTC) From: Yar Tikhiy <yar@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sbin/ifconfig ifvlan.c Message-ID: <200601281638.k0SGcSrG041082@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
yar 2006-01-28 16:38:28 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_6)
sbin/ifconfig ifvlan.c
Log:
Temporarily back out the last change, rev. 1.7.2.2.
The problem with it was that it swapped the relative order of IP
assignment and parent interface attachment. The present if_vlan
code gets certain flags from the parent, including those meaningful
to the upper layers. E.g., IP assignment to an interface with
IFF_BROADCAST goes somewhat differently from that to a non-broadcast
interface. Consequently, assigning IP before attaching the parent
results in a bogus or missing broadcast address on the vlan interface.
This bug is still here, but at least it won't be triggered by doing
both vlanX configuration steps, IP and vlan+vlandev, in a single
ifconfig invocation, which is usual to setting up vlans via rc.conf.
Work at the global issue is under way.
Revision Changes Path
1.7.2.3 +45 -36 src/sbin/ifconfig/ifvlan.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200601281638.k0SGcSrG041082>