From owner-cvs-all@FreeBSD.ORG Sat Jan 28 16:38:28 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F040616A420; Sat, 28 Jan 2006 16:38:28 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BEA5E43D49; Sat, 28 Jan 2006 16:38:28 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k0SGcSnX041083; Sat, 28 Jan 2006 16:38:28 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k0SGcSrG041082; Sat, 28 Jan 2006 16:38:28 GMT (envelope-from yar) Message-Id: <200601281638.k0SGcSrG041082@repoman.freebsd.org> From: Yar Tikhiy Date: Sat, 28 Jan 2006 16:38:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sbin/ifconfig ifvlan.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jan 2006 16:38:29 -0000 yar 2006-01-28 16:38:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sbin/ifconfig ifvlan.c Log: Temporarily back out the last change, rev. 1.7.2.2. The problem with it was that it swapped the relative order of IP assignment and parent interface attachment. The present if_vlan code gets certain flags from the parent, including those meaningful to the upper layers. E.g., IP assignment to an interface with IFF_BROADCAST goes somewhat differently from that to a non-broadcast interface. Consequently, assigning IP before attaching the parent results in a bogus or missing broadcast address on the vlan interface. This bug is still here, but at least it won't be triggered by doing both vlanX configuration steps, IP and vlan+vlandev, in a single ifconfig invocation, which is usual to setting up vlans via rc.conf. Work at the global issue is under way. Revision Changes Path 1.7.2.3 +45 -36 src/sbin/ifconfig/ifvlan.c