Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 Apr 2017 02:39:02 +0000
From:      Colin Percival <cperciva@tarsnap.com>
To:        Rui Paulo <rpaulo@me.com>, =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= <des@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r317277 - head/sys/crypto/chacha20
Message-ID:  <0100015b9386e2b1-ac40d981-d38e-43f2-9fb5-39e19f928733-000000@email.amazonses.com>
In-Reply-To: <AFC8F371-13A1-4075-BF7C-B1E1D9B04A94@me.com>
References:  <201704220106.v3M16NLH097822@repo.freebsd.org> <AFC8F371-13A1-4075-BF7C-B1E1D9B04A94@me.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 04/21/17 19:33, Rui Paulo wrote:
> On Apr 21, 2017, at 18:06, Dag-Erling Smørgrav <des@freebsd.org> wrote:
>> Author: des
>> Date: Sat Apr 22 01:06:23 2017
>> New Revision: 317277
>> URL: https://svnweb.freebsd.org/changeset/base/317277
>>
>> Log:
>>  Fix counter increment in Salsa and ChaCha.
>>
>>  In my eagerness to eliminate a branch which is taken once per 2^38
>>  bytes of keystream, I forgot that the state words are in host order.
>>  Thus, the counter increment code worked fine on little-endian
>>  machines, but not on big-endian ones.  Switch to a simpler (branchful)
>>  solution.
> 
> I’m surprised there’s no mention of who reviewed your change, especially when you’re changing crypto code.

Reviewed by:	cperciva

-- 
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0100015b9386e2b1-ac40d981-d38e-43f2-9fb5-39e19f928733-000000>