From owner-svn-src-head@FreeBSD.ORG  Mon Oct 21 15:07:58 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 2B0E5115;
 Mon, 21 Oct 2013 15:07:58 +0000 (UTC)
 (envelope-from kp@vega.codepro.be)
Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id DFAB92DDF;
 Mon, 21 Oct 2013 15:07:57 +0000 (UTC)
Received: from vega.codepro.be (unknown [172.16.1.3])
 by venus.codepro.be (Postfix) with ESMTP id 102A811F84;
 Mon, 21 Oct 2013 17:07:53 +0200 (CEST)
Received: by vega.codepro.be (Postfix, from userid 1001)
 id 0BF49946D; Mon, 21 Oct 2013 17:07:53 +0200 (CEST)
Date: Mon, 21 Oct 2013 17:07:53 +0200
From: Kristof Provost <kristof@sigsegv.be>
To: Kirk McKusick <mckusick@FreeBSD.org>
Subject: Re: svn commit: r256808 - head/sys/ufs/ffs
Message-ID: <20131021150752.GC77546@vega.codepro.be>
References: <201310202111.r9KLBfq5076008@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <201310202111.r9KLBfq5076008@svn.freebsd.org>
X-PGP-Fingerprint: E114 D9EA 909E D469 8F57  17A5 7D15 91C6 9EFA F286
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Oct 2013 15:07:58 -0000

Hi Kirk,

On 2013-10-20 21:11:41 (+0000), Kirk McKusick <mckusick@FreeBSD.org> wrote:
> Modified: head/sys/ufs/ffs/ffs_softdep.c
> ==============================================================================
> --- head/sys/ufs/ffs/ffs_softdep.c	Sun Oct 20 21:11:36 2013	(r256807)
> +++ head/sys/ufs/ffs/ffs_softdep.c	Sun Oct 20 21:11:40 2013	(r256808)
> @@ -13686,6 +13686,17 @@ DB_SHOW_COMMAND(mkdirs, db_show_mkdirs)
>  	}
>  }
>  
> +/* exported to ffs_vfsops.c */
> +extern void db_print_ffs(struct ufsmount *ump);
> +void
> +db_print_ffs(struct ufsmount *ump)
> +{
> +	db_printf("mp %p %s devvp %p fs %p su_wl %d su_deps %d su_req %d\n",
> +	    ump->um_mountp, ump->um_mountp->mnt_stat.f_mntonname,
> +	    ump->um_devvp, ump->um_fs, ump->softdep_on_worklist,
> +	    ump->softdep_deps, ump->softdep_req);
> +}
> +
>  #endif /* DDB */
>  
>  #endif /* SOFTUPDATES */
> 
This causes link failures for me:
ffs_vfsops.o: In function `db_show_ffs':
/usr/home/kp/openrd/sys/ufs/ffs/ffs_vfsops.c:2235: undefined reference to `db_print_ffs'
/usr/home/kp/openrd/sys/ufs/ffs/ffs_vfsops.c:2241: undefined reference to `db_print_ffs'

Presumably because I have DDB set, but not SOFTUPDATES.

Regards,
Kristof