From owner-svn-ports-all@freebsd.org Thu Mar 7 17:32:49 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7822F150D4A9; Thu, 7 Mar 2019 17:32:49 +0000 (UTC) (envelope-from yuri@freebsd.org) Received: from shell1.rawbw.com (shell1.rawbw.com [198.144.192.42]) by mx1.freebsd.org (Postfix) with ESMTP id 25A0D69DE7; Thu, 7 Mar 2019 17:32:47 +0000 (UTC) (envelope-from yuri@freebsd.org) Received: from yv.noip.me (c-24-4-39-254.hsd1.ca.comcast.net [24.4.39.254]) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id x27HWd8J059448 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 7 Mar 2019 09:32:40 -0800 (PST) (envelope-from yuri@freebsd.org) X-Authentication-Warning: shell1.rawbw.com: Host c-24-4-39-254.hsd1.ca.comcast.net [24.4.39.254] claimed to be yv.noip.me Reply-To: yuri@freebsd.org Subject: Re: svn commit: r494857 - in head/multimedia/webcamoid: . files To: Gerald Pfeifer Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201903062230.x26MUo8W039525@repo.freebsd.org> From: Yuri Message-ID: <73df7274-1866-1f9f-3b4b-bc74eacff8e2@freebsd.org> Date: Thu, 7 Mar 2019 09:32:38 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Rspamd-Queue-Id: 25A0D69DE7 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.950,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 17:32:49 -0000 On 3/7/19 4:11 AM, Gerald Pfeifer wrote: > This is a little short of a commit log given all the changes to the > port in this commit. Such as... > >> -USES= pkgconfig qmake qt:5 >> +USES= gl gnome pkgconfig qmake qt:5 > ...this > >> -# Workaround for the crash when built with clang that the upstream author says is a bug in clang >> -USE_GCC= yes > ...or this. Plus, with USE_GCC being removed... These two are mundane or self-explanatory, though. "gl gnome" are now required, and workaround isn't needed since the problem is gone. Somebody said before that any idiot can read diffs, no need to repeat them in words. -) >> # Workaround for Bug#224137: devel/qt5-qmake: Doesn't use the right compiler in case USE_GCC is selected >> BINARY_ALIAS= g++=${CXX} > ...this cannot be right any longer. Or at a minimum the comment > referring to USE_GCC cannot be? There are some architectures that use gcc as a default compiler, so this line is relevant, but it could use if/endif block conditioned on gcc being a compiler. I will add this, and related notes to the port. Thank you for your comments, I will try to write mode detailed logs. Yuri