From owner-cvs-src@FreeBSD.ORG Thu May 22 11:38:55 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8385637B401; Thu, 22 May 2003 11:38:55 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3628643FBF; Thu, 22 May 2003 11:38:55 -0700 (PDT) (envelope-from dougb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h4MIcs0U058982; Thu, 22 May 2003 11:38:54 -0700 (PDT) (envelope-from dougb@repoman.freebsd.org) Received: (from dougb@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h4MIcsnQ058981; Thu, 22 May 2003 11:38:54 -0700 (PDT) Message-Id: <200305221838.h4MIcsnQ058981@repoman.freebsd.org> From: Doug Barton Date: Thu, 22 May 2003 11:38:54 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/newfs mkfs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 May 2003 18:38:55 -0000 dougb 2003/05/22 11:38:54 PDT FreeBSD src repository Modified files: sbin/newfs mkfs.c Log: When newfs'ing a partition with UFS2 that had previously been newfs'ed with UFS1, the UFS1 superblocks were not deleted. This allowed any RELENG_4 (or other non-UFS2-aware) fsck to think it knew how to "fix" the file system, resulting in severe data scrambling. This patch is a more advanced version than the one originally submitted. Lukas improved it based on feedback from Kirk, and testing by me. It blanks all UFS1 superblocks (if any) during a UFS2 newfs, thereby causing fsck's that are not UFS2 aware to generate the "SEARCH FOR ALTERNATE SUPER-BLOCK FAILED" message, and exit without damaging the fs. PR: bin/51619 Submitted by: Lukas Ertl Reviewed by: kirk Approved by: re (scottl) Revision Changes Path 1.77 +24 -0 src/sbin/newfs/mkfs.c