From owner-freebsd-bugs@freebsd.org Tue Jun 23 15:10:38 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5026A357D31 for ; Tue, 23 Jun 2020 15:10:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 49rqTp1WMnz4fy9 for ; Tue, 23 Jun 2020 15:10:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 33F3F357D30; Tue, 23 Jun 2020 15:10:38 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 33BAB357CCC for ; Tue, 23 Jun 2020 15:10:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49rqTp0g3Dz4flD for ; Tue, 23 Jun 2020 15:10:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 123FB22685 for ; Tue, 23 Jun 2020 15:10:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 05NFAbbM022435 for ; Tue, 23 Jun 2020 15:10:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 05NFAbLP022432 for bugs@FreeBSD.org; Tue, 23 Jun 2020 15:10:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 247494] sort(1) order affected by LC_CTYPE Date: Tue, 23 Jun 2020 15:10:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 12.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: cem@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2020 15:10:38 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D247494 --- Comment #4 from Conrad Meyer --- Ok, so radix sort only goes byte-at-a-time; we can't allocate memory for all wchar_t space (4 GB). Here are the wchar_t representations of the two characters: echo =E8=80=B3=E8=84=B3 | iconv -f utf-8 -t ucs-4 | hd 00000000 00 00 80 33 00 00 81 33 |...3...3....| ^ first ^ second It incorrectly looks at the least significant byte of the wchar_t, observes that 33 =3D=3D 33 and invokes collate to attempt to differentiate the two s= trings.=20 But using radixsort's level is wrong for bwscoll, which expects an offset in wchar_t. Since radixsort has only processed 1/4 of a wchar_t, this is a bo= gus offset. I'm not sure how our radixsort is supposed to work, honestly. It seems pre= tty broken, even for ASCII. It should be able to bucket multiple keys that sha= re a character per level, but it doesn't =E2=80=94 it falls back on comparison i= n that case. --=20 You are receiving this mail because: You are the assignee for the bug.=