From owner-freebsd-audit  Mon Apr 30 20:50:28 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by hub.freebsd.org (Postfix) with ESMTP id DBFF537B423
	for <FreeBSD-audit@FreeBSD.ORG>; Mon, 30 Apr 2001 20:50:25 -0700 (PDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1])
	by harmony.village.org (8.11.3/8.11.1) with ESMTP id f413oOR56065;
	Mon, 30 Apr 2001 21:50:24 -0600 (MDT)
	(envelope-from imp@harmony.village.org)
Message-Id: <200105010350.f413oOR56065@harmony.village.org>
To: Mike Heffner <mheffner@vt.edu>
Subject: Re: Small patch to allow mail to read Eudora mailboxes 
Cc: FreeBSD-audit <FreeBSD-audit@FreeBSD.ORG>
In-reply-to: Your message of "Mon, 30 Apr 2001 23:44:42 EDT."
		<XFMail.20010430234442.mheffner@vt.edu> 
References: <XFMail.20010430234442.mheffner@vt.edu>  
Date: Mon, 30 Apr 2001 21:50:24 -0600
From: Warner Losh <imp@harmony.village.org>
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

In message <XFMail.20010430234442.mheffner@vt.edu> Mike Heffner writes:
: +               if (count >= 2 && linebuf[count-1] == '\n' &&
: +                   linebuf[count - 2] == '\r')
: +                       linebuf[count - 2] = linebuf[--count];

Why not just

	if (count >= 2 && linebuf[count-1] == '\n' &&
	    linebuf[count - 2] == '\r') {
		count--;
		linebuf[count - 1] = '\n';
	}

which is clearer and you avoid a hard to understand (and maybe ill
defined) side effect with the --count part of the statement.

Warner


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message