Date: Fri, 20 May 2016 07:48:15 -0700 From: John Baldwin <jhb@freebsd.org> To: Allan Jude <allanjude@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r300257 - in head/sys/boot/i386: libi386 zfsboot Message-ID: <1780135.VYYOsNudFi@ralph.baldwin.cx> In-Reply-To: <201605200141.u4K1flpV094958@repo.freebsd.org> References: <201605200141.u4K1flpV094958@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, May 20, 2016 01:41:47 AM Allan Jude wrote: > Author: allanjude > Date: Fri May 20 01:41:47 2016 > New Revision: 300257 > URL: https://svnweb.freebsd.org/changeset/base/300257 > > Log: > Fixup the geliboot sector rounding code > > Replace all rounding with the round{up,down}2 macros > a missing set of braces caused the previous code to be incorrect > > replace alloca() with malloc() because alloca() can return an allocation > that is actually invalid, causing boot to fail No, you have to revert the malloc! malloc() can be anywhere. The alloca is _on purpose_ to get a bufer below 1MB so that it will work with all devices. Some BIOSes can only store data in the first 1MB. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1780135.VYYOsNudFi>