From owner-freebsd-ports@FreeBSD.ORG  Sun Apr  1 11:05:23 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mandree.no-ip.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id 3BA0D1065673
	for <freebsd-ports@freebsd.org>; Sun,  1 Apr 2012 11:05:23 +0000 (UTC)
	(envelope-from mandree@FreeBSD.org)
Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1])
	by apollo.emma.line.org (Postfix) with ESMTP id 3698D23CEAF
	for <freebsd-ports@freebsd.org>; Sun,  1 Apr 2012 13:05:22 +0200 (CEST)
Message-ID: <4F783672.9040107@FreeBSD.org>
Date: Sun, 01 Apr 2012 13:05:22 +0200
From: Matthias Andree <mandree@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.2.28) Gecko/20120313 Mnenhy/0.8.3 Thunderbird/3.1.20
MIME-Version: 1.0
To: freebsd-ports@freebsd.org
References: <4F76ABE6.206@FreeBSD.org> <4F76C3B7.5010305@yandex.ru>
In-Reply-To: <4F76C3B7.5010305@yandex.ru>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: rawtherapee 4.0.7 build failure on 9-STABLE amd64
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Apr 2012 11:05:23 -0000

Am 31.03.2012 10:43, schrieb Ruslan Mahmatkhanov:
> Matthias Andree wrote on 31.03.2012 11:01:
>> Ruslan,
>>
>> I cannot build rawtherapee 4.0.7 on 9-STABLE amd64,
>> re-running it after failure with "make MAKE_JOBS_UNSAFE=yes" yields:
> [...]
>> math.h line 239 declares "double log2(double);", so I presume that
>> patch-rtengine_improcfun.h proves harmful here; the "#ifndef log2(x)" is
>> bogus if log2 isn't declared as macro (and is actually what breaks the
>> compile), and the macro is #define log2(x) ((log(x)/log(2)).
>>
>> It might be more useful to do this instead:
>>
>> static const  double lnOf2 = log(2);
>> static inline double log2(double x) { return log(x)/lnOf2; }
>>
>> or possibly checking math.h for log2() before adding the patch.
>>
>> I'm afraid I won't have the time to do that now; could you?
>>
>> Thanks.
>>
>> Best,
>> Matthias
>>
>>
> 
> Should be fixed now. That was a last minute change when I realize that
> it doesn't build on 8.2. I didn't rechecked it on 9/10 after the fix was
> applied. Apologies and thanks for the hands up.

Thanks, works for me now.  I'd only used MAKE_JOBS_UNSAFE to be sure
there weren't any artifacts, and I get sequential logging.

> Btw, it builds fine to me on -current amd64 with MAKE_JOBS_SAFE=yes,
> should I add this knob to Makefile?

Assuming it uses cmake as a proven and established build utility, I'd
say 'go for it'.

Thanks for the prompt fix!

Best,
Matthias