From owner-svn-ports-head@FreeBSD.ORG Thu Jul 24 21:03:11 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8D788AF4; Thu, 24 Jul 2014 21:03:11 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 60CFF2834; Thu, 24 Jul 2014 21:03:11 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.8/8.14.8) with ESMTP id s6OL3Bwb094489; Thu, 24 Jul 2014 21:03:11 GMT (envelope-from bdrewery@svn.freebsd.org) Received: (from bdrewery@localhost) by svn.freebsd.org (8.14.8/8.14.8/Submit) id s6OL3BpL094488; Thu, 24 Jul 2014 21:03:11 GMT (envelope-from bdrewery@svn.freebsd.org) Message-Id: <201407242103.s6OL3BpL094488@svn.freebsd.org> From: Bryan Drewery Date: Thu, 24 Jul 2014 21:03:11 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r362849 - head/Mk/Scripts X-SVN-Group: ports-head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2014 21:03:11 -0000 Author: bdrewery Date: Thu Jul 24 21:03:10 2014 New Revision: 362849 URL: http://svnweb.freebsd.org/changeset/ports/362849 QAT: https://qat.redports.org/buildarchive/r362849/ Log: - Fix check-plist so that its 'files in plist but missing from STAGEDIR' check does not incorrectly ignore plist items in %%DOCSDIR%% and %%EXAMPLESDIR%%. It was incorrectly ignoring these items when %%PORTDOCS%% or %%PORTEXAMPLES%% was missing. This manifested as a failure in 'make package' later when pkg(8) detected the missing files. With hat: portmgr Modified: head/Mk/Scripts/check-stagedir.sh Modified: head/Mk/Scripts/check-stagedir.sh ============================================================================== --- head/Mk/Scripts/check-stagedir.sh Thu Jul 24 20:49:29 2014 (r362848) +++ head/Mk/Scripts/check-stagedir.sh Thu Jul 24 21:03:10 2014 (r362849) @@ -252,13 +252,20 @@ setup_plist_seds() { sed_plist_sub=$(echo "${PLIST_SUB_SED}" | /bin/sh ${SCRIPTSDIR}/plist_sub_sed_sort.sh) unset PLIST_SUB_SED - sed_files="s!${PREFIX}/!!g; ${sed_plist_sub} ${sed_portdocsexamples} \ - /^share\/licenses/d;" + # Used for generate_plist + sed_files_gen="s!${PREFIX}/!!g; ${sed_plist_sub} \ + ${sed_portdocsexamples} /^share\/licenses/d;" + sed_dirs_gen="s!${PREFIX}/!!g; ${sed_plist_sub} s,^,@dirrmtry ,; \ + ${sed_portdocsexamples} \ + s!@dirrmtry \(/.*\)!@unexec rmdir \"\1\" >/dev/null 2>\&1 || :!; \ + /^@dirrmtry share\/licenses/d;" + # These prevent ignoring DOCS/EXAMPLES dirs with sed_portdocsexamples + sed_files="s!${PREFIX}/!!g; ${sed_plist_sub} /^share\/licenses/d;" sed_dirs="s!${PREFIX}/!!g; ${sed_plist_sub} s,^,@dirrmtry ,; \ - ${sed_portdocsexamples} \ s!@dirrmtry \(/.*\)!@unexec rmdir \"\1\" >/dev/null 2>\&1 || :!; \ /^@dirrmtry share\/licenses/d;" + } # Generate plist from staged files @@ -269,7 +276,7 @@ generate_plist() { find ${STAGEDIR} -type f -o -type l | sort | \ sed -e "s,${STAGEDIR},," >${WRKDIR}/.staged-files comm -13 ${WRKDIR}/.plist-files ${WRKDIR}/.staged-files | \ - sed -e "${sed_files}" \ + sed -e "${sed_files_gen}" \ >>${WRKDIR}/.staged-plist || : ### HANDLE DIRS @@ -282,7 +289,7 @@ generate_plist() { >${WRKDIR}/.staged-dirs-dfs-sorted # Find all staged dirs and then sort them by depth-first (find -ds) comm -13 ${WRKDIR}/.traced-dirs ${WRKDIR}/.staged-dirs-sorted \ - | sort_dfs | sed "${sed_dirs}" \ + | sort_dfs | sed "${sed_dirs_gen}" \ >>${WRKDIR}/.staged-plist || : }