From owner-svn-ports-all@freebsd.org Fri Dec 14 09:30:56 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C668D1327E86; Fri, 14 Dec 2018 09:30:56 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6A51E95667; Fri, 14 Dec 2018 09:30:56 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from atuin.in.mat.cc (unknown [IPv6:2a01:678:42:ffff:3e15:c2ff:fec4:452e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id B64FB17647; Fri, 14 Dec 2018 09:30:52 +0000 (UTC) (envelope-from mat@FreeBSD.org) Date: Fri, 14 Dec 2018 10:30:51 +0100 From: Mathieu Arnold To: Romain =?utf-8?B?VGFydGnDqHJl?= Cc: Jan Beich , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r487403 - head/databases/puppetdb-cli Message-ID: <20181214093051.stocdnar7vrhmark@atuin.in.mat.cc> References: <201812140259.wBE2xbuT015992@repo.freebsd.org> <20181214070225.GA13003@blogreen.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="32caxjjuk3wpeeqt" Content-Disposition: inline In-Reply-To: <20181214070225.GA13003@blogreen.org> User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 6A51E95667 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.99)[-0.988,0]; REPLY(-4.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 09:30:57 -0000 --32caxjjuk3wpeeqt Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 13, 2018 at 09:02:25PM -1000, Romain Tarti=E8re wrote: > On Fri, Dec 14, 2018 at 06:19:50AM +0100, Jan Beich wrote: > > Romain Tarti=E8re writes: > >=20 > > > +BROKEN_SSL_REASON_libressl=3D Needs an old version of OpenSSL (older= than 1.1) > >=20 > > Does it build fine with DEFAULT_VERSIONS+=3Dlibressl-devel ? >=20 > Of course not, good catch! Probably the same for openssl-devel but it > seems absent as of today, so I don't know if we should add it. >=20 > > > +.include > >=20 > > .include would have been enough. >=20 > Yes, it seems to be okay too. I was following > https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.h= tml#dads-after-port-mk >=20 > > > +.if ${OSVERSION} >=3D 1200085 > >=20 > > Checking OSVERSION without OPSYS is illegal. DragonFly has OSVERSION=3D= 9999999 > > with LibreSSL 2.4.4 in base. > >=20 > > https://github.com/DragonFlyBSD/DPorts/blob/f18014a15a13/Mk/bsd.port.mk= #L1184 > > https://github.com/DragonFlyBSD/DragonFlyBSD/blob/bd84e83893b2/crypto/l= ibressl/README.DRAGONFLY >=20 > Fixed! >=20 > > > +BROKEN_SSL+=3D base > >=20 > > BROKEN_SSL=3Dbase is *not supported* by USES=3Dssl, and BROKEN_SSL cann= ot set > > after bsd.port.pre.mk because USES=3Dssl was already processed by that = time. >=20 > D'oh! Maybe this information may have it's place in the Porter's Handboo= k: > https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.h= tml#uses-ssl No, the fact that it is not supported is a bug, but as nobody ever said it was not working, I only discovered it last week or something. --=20 Mathieu Arnold --32caxjjuk3wpeeqt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlwTeEtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkhMxg/+MKAJgAtpuV8pNpkmRJfVUtj0pZQnUsSS5ohwKpsO6fJDxVfXU5et5YCY RIGw+X6yuNiW/R/9KjIlGwPtZtfV1/lh2oZXe01u9qk4aa85E/ZiNlt+enp6i7S1 N95gy2H5v8jmR8c1zaSCKLZH5byXvgUeQICA4sdiNy4bBQTDFIFVrNVW5k8VqBYI CWIFA+7vE8jij4nyM2Eh9k2+pnRSnyz16hKzKhcmxiJ/MMiRV/rmsm63G6GAz5fv RPaYHIqRV3JvYIuDUTqq0mFkePr2RLAngVkPkF7BgzugHBzVCq8JTOaV8ppkQ/vd vIJ1x3cZeFikD4WZGUEz97lRHBn2VF0tkaCnYKlio6FNsGTmTVsD2gwPlgTja+sQ JBWcNlTBNmyczyFiDGg43fV+AQq3BS6XOLp7ISNG7c+2HnL8QNHoQ0roYB6kcqXN LXDTpwNxbXoT8b/g6C1ej1IqwjfKEoyAMye8vybv46s8oadpn00Z1aCL+NG9LyIU VmFc7QpLjmyoJLQ5iC8j93yPatVyFpgKkrYQnV7YTkpW3vA9QZnfz635ULjTPWK6 AEbyXXGpOf8Yt+6WYhON1rSY6e6yTYOi0agvlJ+4mcazDIjsdcaxcNvjwOw0liIJ 0M6KdaqYMhQVEHwStkd/0vcX0hQCIV5k+XWN+vijc1GSRsaA9WU= =yvyh -----END PGP SIGNATURE----- --32caxjjuk3wpeeqt--