From owner-freebsd-fs Wed Dec 8 3: 3:37 1999 Delivered-To: freebsd-fs@freebsd.org Received: from ns1.yes.no (ns1.yes.no [195.204.136.10]) by hub.freebsd.org (Postfix) with ESMTP id 5A3BB14C40 for ; Wed, 8 Dec 1999 03:03:17 -0800 (PST) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [195.204.143.218]) by ns1.yes.no (8.9.3/8.9.3) with ESMTP id MAA08227; Wed, 8 Dec 1999 12:03:16 +0100 (CET) Received: (from eivind@localhost) by bitbox.follo.net (8.8.8/8.8.6) id MAA20742; Wed, 8 Dec 1999 12:03:16 +0100 (MET) Date: Wed, 8 Dec 1999 12:03:16 +0100 From: Eivind Eklund To: Michael Hancock Cc: fs@FreeBSD.ORG Subject: Re: Final call for VOP_ISLOCKED objections Message-ID: <19991208120316.Q14851@bitbox.follo.net> References: <19991208014115.L14851@bitbox.follo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: ; from michaelh@cet.co.jp on Wed, Dec 08, 1999 at 02:53:48PM +0900 Sender: owner-freebsd-fs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Wed, Dec 08, 1999 at 02:53:48PM +0900, Michael Hancock wrote: > I think the DEBUG_VFS_LOCKS stuff was temporary debugging infrastructure, > put into debug NFS. The comments seems indicate they were intended to debug all locks; and this is what I'm using it for, anyway. > When SMP gets more fine grained I'm not sure how useful they will > be. i.e. race conditions between checking the assertion and the > protected code. This may become a problem for some of the assertions at some point, yes, but to get to that point I think we will need quite a few other code sweeps to fix assumptions that the kernel is single-threaded. Before then, I hope to have cleaned up the VFS locking protocols (both use and specification) well enough that the assertions won't be crucial any more. > If the changes to vnode_if.src/vnode_if.sh are just comments then it > probably isn't a problem. The changes to vnode_if.src are just comments (about new available lockspecs). The changes to vnode_if.sh are to take new lockspecs (of which none are yet available) and turn them into assertions in the generated VOP code. Eivind. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-fs" in the body of the message