From nobody Mon Feb 27 18:27:12 2023 X-Original-To: emulation@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PQTVw3jl7z3vRxT for ; Mon, 27 Feb 2023 18:27:20 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PQTVv3Z5Zz41tP for ; Mon, 27 Feb 2023 18:27:19 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of brooks@spindle.one-eyed-alien.net has no SPF policy when checking 199.48.129.229) smtp.mailfrom=brooks@spindle.one-eyed-alien.net; dmarc=none Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id C35D03C0199; Mon, 27 Feb 2023 18:27:12 +0000 (UTC) Date: Mon, 27 Feb 2023 18:27:12 +0000 From: Brooks Davis To: Kevin Oberman Cc: "freebsd-emulation@freebsd.org" Subject: Re: virtualbon-ose-kmod build fails with 14-CURRENT and llvm15 Message-ID: References: List-Id: Development of Emulators of other operating systems List-Archive: https://lists.freebsd.org/archives/freebsd-emulation List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-emulation@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-Spamd-Result: default: False [-1.78 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.98)[-0.981]; FORGED_SENDER(0.30)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_TO(0.00)[gmail.com]; R_SPF_NA(0.00)[no SPF record]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]; MLMMJ_DEST(0.00)[emulation@freebsd.org]; TO_DN_ALL(0.00)[]; FROM_NEQ_ENVFROM(0.00)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; FREEFALL_USER(0.00)[brooks]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4PQTVv3Z5Zz41tP X-Spamd-Bar: - X-ThisMailContainsUnwantedMimeParts: N On Sun, Feb 26, 2023 at 09:45:34AM -0800, Kevin Oberman wrote: > I updated my system yesterday. I then tried to rebuild virtualbox-ose-kmo= d. > This fails under llvm15. The same source code built successfully with > llvm14, so I assume that the code has a problem with 15. I suspect that 15 > changed some default and declared this as an error, but may be "fixed" wi= th > the proper build option. >=20 > Here is the command and error that I see: >=20 > cc -O2 -pipe -fno-strict-aliasing -DRT_OS_FREEBSD -DIN_RING0 -DIN_RT_R0 > -DIN_SUP_R0 -DSUPDRV_WITH_RELEASE_LOGGER -DVBOX -DRT_WITH_VBOX -w > -DVBOX_WITH_HARDENING -DVBOX_WITH_64_BITS_GUESTS -DRT_ARCH_AMD64 -Werror > -D_KERNEL -DKLD_MODULE -nostdinc -Iinclude -I. -Ir0drv -include > /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-6.1.36/out/freeb= sd.amd64/release/bin/src/vboxdrv/opt_global.h > -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common > -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer > -fdebug-prefix-map=3D./machine=3D/usr/src/sys/amd64/include > -fdebug-prefix-map=3D./x86=3D/usr/src/sys/x86/include > -fdebug-prefix-map=3D./i386=3D/usr/src/sys/i386/include -MD > -MF.depend.SUPDrv-freebsd.o -MTSUPDrv-freebsd.o -mcmodel=3Dkernel > -mno-red-zone -mno-mmx -mno-sse -msoft-float > -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector > -Wall -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes > -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign > -D__printf__=3D__freebsd_kprintf__ -Wmissing-include-dirs > -fdiagnostics-show-option -Wno-unknown-pragmas > -Wno-error=3Dtautological-compare -Wno-error=3Dempty-body > -Wno-error=3Dparentheses-equality -Wno-error=3Dunused-function > -Wno-error=3Dpointer-sign -Wno-error=3Dshift-negative-value > -Wno-address-of-packed-member -Wno-error=3Darray-parameter > -Wno-error=3Ddeprecated-non-prototype -Wno-error=3Dstrict-prototypes > -Wno-error=3Dunused-but-set-variable -Wno-format-zero-length -mno-aes > -mno-avx -std=3Diso9899:1999 -c > /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-6.1.36/out/freeb= sd.amd64/release/bin/src/vboxdrv/freebsd/SUPDrv-freebsd.c > -o SUPDrv-freebsd.o > /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-6.1.36/out/freeb= sd.amd64/release/bin/src/vboxdrv/freebsd/SUPDrv-freebsd.c:433:50: > error: incompatible pointer to integer conversion passing 'void *' to > parameter of type 'RTR3PTR' (aka 'unsigned long') [-Wint-conversion] > if (RT_FAILURE(RTR0MemUserCopyFrom(&Hdr, pvUser, sizeof(Hdr)))) > ^~~~~~ > include/iprt/errcore.h:99:58: note: expanded from macro 'RT_FAILURE' >=20 > Any help appreciated. I really need virtualbox. I think I may force it to > build with llvm14, but I's prefer a fix to build with llvm15. Assuming the code works in practice, it should just be a matter of adding a cast (void *)(uintptr_t)pvUser. -- Brooks