From nobody Wed Feb 22 10:44:11 2023 X-Original-To: freebsd-arch@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PMCT26llfz3srQq for ; Wed, 22 Feb 2023 10:44:22 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PMCT21QJfz4Q0q for ; Wed, 22 Feb 2023 10:44:22 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.17.1/8.17.1) with ESMTPS id 31MAiBuo045997 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 22 Feb 2023 12:44:15 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 31MAiBuo045997 Received: (from kostik@localhost) by tom.home (8.17.1/8.17.1/Submit) id 31MAiB21045996; Wed, 22 Feb 2023 12:44:11 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 22 Feb 2023 12:44:11 +0200 From: Konstantin Belousov To: Warner Losh Cc: freebsd-arch@freebsd.org Subject: Re: making identify_hypervisor arch independent Message-ID: References: <20230222040556.GP95670@funkthat.com> List-Id: Discussion related to FreeBSD architecture List-Archive: https://lists.freebsd.org/archives/freebsd-arch List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arch@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on tom.home X-Rspamd-Queue-Id: 4PMCT21QJfz4Q0q X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Tue, Feb 21, 2023 at 10:22:41PM -0700, Warner Losh wrote: > On Tue, Feb 21, 2023 at 9:06 PM John-Mark Gurney wrote: > > > Hello, > > > > I have a pending diff (https://reviews.freebsd.org/D38721) that will make > > SMBIOS work on arm64 systems (specifically under qemu, but likely it may > > add support for other EFI arm64 systems that have SMBIOS as well). > > > > The goal is to support identifying that we are running as a guest under > > QEMU so that we automatically switch to hz=100 on arm64. > > > > Currently there is code in x86/x86/identcpu.c that has code to identify > > hypervisers via SMBIOS, so I'd like to move most of identify_hypervisor > > to a new location so that arm64 code can call it as well. > > > > Where should I put it? kern/subr_identsmbios.c? And make it optional > > on EFIRT for arm64 and standard on x86? > > > > I'd do kern/subr_smbios.c. > > I'd be tempted to make it standard, since EFI is basically required for > arm64. It's not dependent at all on efi run time support. Why not extend existing sys/dev/smbios? We do not put hardware-specific stuff in generic kernel sources' directory. > > > > I briefly thought of dev/smbios, BUT, that brings up another issue, > > I think we should deorbit dev/smbios, and move smbios.h to dev/ipmi, > > because as far as I can tell, the device does nothing useful. It > > allocates the resource, but nothing that I can find in the tree attempts > > to use/access the device, and it doesn't expose any interface. The > > header is only used by dev/ipmi for the structure, but not the device, > > as ipmi does it's own parsing of the table. > > > > All of the uses of smbios data is getting it via kenv which is populated > > via loader (libsa). > > > > I'd be tempted to move all the smbios walking into subr_smbios.c. > > All the other smbios stuff does depend on the boot loader walking > and parsing the table and setting that in the kenv... I'd almost be tempted > to make those into wrappers to make it harder to misspell the string they > all pass in... Even if it's just a wrapper around kenv_getenv with the > right string... They are mostly used for 'quirks'. > > Either way, I think sys/dev/smbios likely has limited value... It would be > different if it provided some way to get the raw smbios table... But as > it is, I think all programs that parse it get it via /dev/mem... > > Warner > > Warner > > > > Thanks. > > > > -- > > John-Mark Gurney Voice: +1 415 225 5579 > > > > "All that I will do, has been done, All that I have, has not." > > > >