From owner-cvs-src@FreeBSD.ORG Wed May 9 07:01:23 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7287616A406 for ; Wed, 9 May 2007 07:01:23 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id 3994C13C468 for ; Wed, 9 May 2007 07:01:23 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 73712 invoked from network); 9 May 2007 07:01:25 -0000 Received: from ppp-71-139-36-90.dsl.snfc21.pacbell.net (HELO ?10.0.5.16?) (nate-mail@71.139.36.90) by root.org with ESMTPA; 9 May 2007 07:01:25 -0000 Message-ID: <464172B0.4010507@root.org> Date: Wed, 09 May 2007 00:05:20 -0700 From: Nate Lawson User-Agent: Thunderbird 1.5.0.9 (X11/20070214) MIME-Version: 1.0 To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= References: <200704222233.l3MMXUKH045452@repoman.freebsd.org> <86abwzio7t.fsf@dwp.des.no> <462CD3FD.6080300@root.org> <86tzurqp4d.fsf@dwp.des.no> <864pmn5lvd.fsf@dwp.des.no> <4640D8AA.40101@root.org> <86lkfzm2m7.fsf@dwp.des.no> In-Reply-To: <86lkfzm2m7.fsf@dwp.des.no> X-Enigmail-Version: 0.94.2.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch fetch.3 ftp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2007 07:01:23 -0000 Dag-Erling Smørgrav wrote: > Nate Lawson writes: >> BTW, is there any reason to redo the "MODE S" and "TYPE I" commands >> after MDTM? > > MODE and TYPE commands are always issued before an MDTM (fetchStat*()) > or RETR (fetchGet*()), because the code assumes that they can vary > from one call to another. This is true for TYPE (you can specify it > in the URL), and I chose to assume that it might also be the case for > MODE, even though it currently isn't. > > (remember that the FTP code will reuse the control connection across > calls as long as the requested URLs are on the same server) Could it be possible to check the values from the URL used to derive TYPE for RETR and then if it's the same as the value for MDTM, don't reissue it? Same for MODE. -- Nate