Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 23 Mar 2018 19:18:02 -0700 (PDT)
From:      Don Lewis <truckman@FreeBSD.org>
To:        Tobias Kortkamp <tobik@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r465415 - head/devel/meson
Message-ID:  <tkrat.81c3c443974b3e39@FreeBSD.org>
In-Reply-To: <1521849971.1712146.1314190536.51DB2DC6@webmail.messagingengine.com>
References:  <201803232334.w2NNYEpY018118@repo.freebsd.org> <1521849971.1712146.1314190536.51DB2DC6@webmail.messagingengine.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 24 Mar, Tobias Kortkamp wrote:
> On Sat, Mar 24, 2018, at 00:34, Don Lewis wrote:
>> Author: truckman
>> Date: Fri Mar 23 23:34:14 2018
>> New Revision: 465415
>> URL: https://svnweb.freebsd.org/changeset/ports/465415
>> 
>> Log:
>>   Update devel/meson to version 0.45.
>>   
>>   Switch to USE_GITHUB.
>>   
>>   PR:		226879
>>   Submitted by:	cy
>> 
>> Modified:
>>   head/devel/meson/Makefile
>>   head/devel/meson/distinfo
>> 
>> Modified: head/devel/meson/Makefile
>> ==============================================================================
>> --- head/devel/meson/Makefile	Fri Mar 23 23:19:53 2018	(r465414)
>> +++ head/devel/meson/Makefile	Fri Mar 23 23:34:14 2018	(r465415)
>> @@ -2,7 +2,7 @@
>>  # $FreeBSD$
>>  
>>  PORTNAME=	meson
>> -PORTVERSION=	0.44.1
>> +PORTVERSION=	0.45
>>  CATEGORIES=	devel python
>>  MASTER_SITES=	https://github.com/mesonbuild/${PORTNAME}/releases/
>> download/${PORTVERSION}/
>>  
>> @@ -15,6 +15,8 @@ LICENSE_FILE=	${WRKSRC}/COPYING
>>  RUN_DEPENDS=	ninja:devel/ninja
>>  
>>  USES=		python:3.4+
>> +USE_GITHUB=	yes
>> +GH_ACCOUNT=	mesonbuild
>>  USE_PYTHON=	autoplist distutils noflavors
>>  NO_ARCH=	yes
>>  
>> 
>> Modified: head/devel/meson/distinfo
>> ==============================================================================
>> --- head/devel/meson/distinfo	Fri Mar 23 23:19:53 2018	(r465414)
>> +++ head/devel/meson/distinfo	Fri Mar 23 23:34:14 2018	(r465415)
>> @@ -1,3 +1,3 @@
>> -TIMESTAMP = 1519672364
>> -SHA256 (meson-0.44.1.tar.gz) = 
>> 2ea1a721574adb23160b6481191bcc1173f374e02b0ff3bb0ae85d988d97e4fa
>> -SIZE (meson-0.44.1.tar.gz) = 1136478
>> +TIMESTAMP = 1521831968
>> +SHA256 (mesonbuild-meson-0.45_GH0.tar.gz) = 
>> 7c579b98ee09ddcfc99e92a9ffd0cf1197bf2ad00b6498061bb5f0ad8e343a26
>> +SIZE (mesonbuild-meson-0.45_GH0.tar.gz) = 1393557
>> 
> 
> Hi,
> 
> upstream provides a release tarball.  There is no reason to USE_GITHUB
> here.
> 
> Besides that 0.45 is a branch not a tag i.e. it's subject to change
> when upstream pushes commits to it!
> 
> I would suggest to either revert the USE_GITHUB change and continue
> using the release tarball or use the 0.45.0 or 0.45.1 tag.  Either way
> PORTVERSION needs to be one of 0.45.0 or 0.45.1 because there is no
> 0.45 release.
> 
> If you keep USE_GITHUB then MASTER_SITES can be removed too.

Thanks.  I'll commit the fix later tonight after I have had a chance to
test it.




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?tkrat.81c3c443974b3e39>