From owner-cvs-usrsbin  Fri Oct 24 16:21:40 1997
Return-Path: <owner-cvs-usrsbin>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id QAA28111
          for cvs-usrsbin-outgoing; Fri, 24 Oct 1997 16:21:40 -0700 (PDT)
          (envelope-from owner-cvs-usrsbin)
Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id QAA28098;
          Fri, 24 Oct 1997 16:21:18 -0700 (PDT)
          (envelope-from brian@awfulhak.org)
Received: from gate.lan.awfulhak.org (localhost [127.0.0.1])
	by awfulhak.demon.co.uk (8.8.5/8.8.5) with ESMTP id AAA25601;
	Sat, 25 Oct 1997 00:20:58 +0100 (BST)
Message-Id: <199710242320.AAA25601@awfulhak.demon.co.uk>
X-Mailer: exmh version 2.0zeta 7/24/97
To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru>
cc: Brian Somers <brian@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG,
        cvs-all@FreeBSD.ORG, cvs-usrsbin@FreeBSD.ORG
Subject: Re: cvs commit: src/usr.sbin/ppp chat.c command.c defs.h main.c modem.c timer.c 
In-reply-to: Your message of "Sat, 25 Oct 1997 03:06:20 +0400."
             <Pine.BSF.3.96.971025030449.10241A-100000@lsd.relcom.eu.net> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Sat, 25 Oct 1997 00:20:58 +0100
From: Brian Somers <brian@awfulhak.org>
Sender: owner-cvs-usrsbin@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> On Fri, 24 Oct 1997, Brian Somers wrote:
> 
> > brian       1997/10/24 15:36:34 PDT
> > 
> >   Modified files:
> >     usr.sbin/ppp         chat.c command.c defs.h main.c modem.c 
> >                          timer.c 
> >   Log:
> >   sleep => nointr_sleep
> >   usleep => nointr_usleep
> >   (not just a #define)
> 
> I already think about this way... Someone can add new sleep()s into code
> not thinking that it can be interrupted, so I decide to do #define.

This works both ways though - with the #define we're obscuring the 
fact that it's not the *real* [u]sleep().

I considered having a #define sleep DontUseSleep, but then 
retrospectively thought that people should really test their changes 
(and figure out that sleep is a no-no).

> -- 
> Andrey A. Chernov
> <ache@nietzsche.net>
> http://www.nagual.pp.ru/~ache/
> 

-- 
Brian <brian@Awfulhak.org>, <brian@FreeBSD.org>, <bri@OpenBSD.org>
      <http://www.Awfulhak.org>
Don't _EVER_ lose your sense of humour....