From owner-svn-src-all@freebsd.org Sat Apr 22 05:41:03 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D70AED4AEF0; Sat, 22 Apr 2017 05:41:03 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 52C2A779; Sat, 22 Apr 2017 05:41:03 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v3M5ewfI034526 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 22 Apr 2017 08:40:58 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v3M5ewfI034526 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id v3M5ewjh034525; Sat, 22 Apr 2017 08:40:58 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 22 Apr 2017 08:40:58 +0300 From: Konstantin Belousov To: John Baldwin Cc: Eric Badger , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r315949 - in stable: 10/sys/kern 10/sys/sys 10/tests/sys/kern 11/sys/kern 11/sys/sys 11/tests/sys/kern Message-ID: <20170422054058.GM1788@kib.kiev.ua> References: <201703251333.v2PDXOmS004369@repo.freebsd.org> <6768216.Fy5yUeFf9F@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6768216.Fy5yUeFf9F@ralph.baldwin.cx> User-Agent: Mutt/1.8.0 (2017-02-23) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Apr 2017 05:41:03 -0000 On Fri, Apr 21, 2017 at 03:11:00PM -0700, John Baldwin wrote: > So this MFC happens to break the KBI of 'struct thread' because > 'struct sigqueue' is embedded in 'struct thread' (rather than > a pointer). This apparently results in panics if you use an > nvidia-driver package built on 11.0-release on 11.0-stable, and > that's the type of KBI we try to preserve. (We tend to only add new > fields to the end of 'struct thread' and 'struct proc' in stable for > example.) This one is a bit ugly to deal with though. I wonder if > for the stable branches only if we could move the sq_ptrace out of > the sigqueue struct and add it as a new field to the end of 'struct > thread' explicitly? It would probably be pretty hacky, but it would be > good to fix this before 11.1 so that the KBI wouldn't be broken for a > user going from 11.0 to 11.1. It might be easier to repurpose existing td_sigqueue as padding with corrected size, and place real sigqueue at the end of the structure. add