From owner-svn-ports-head@freebsd.org Sat Dec 16 18:59:45 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6543E8B459; Sat, 16 Dec 2017 18:59:45 +0000 (UTC) (envelope-from woodsb02@gmail.com) Received: from mail-vk0-x22c.google.com (mail-vk0-x22c.google.com [IPv6:2607:f8b0:400c:c05::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7CB996E91E; Sat, 16 Dec 2017 18:59:45 +0000 (UTC) (envelope-from woodsb02@gmail.com) Received: by mail-vk0-x22c.google.com with SMTP id y187so7467796vkd.2; Sat, 16 Dec 2017 10:59:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eKYX+CBV81RDb2zb68+tE3JHzZCrSEBZ6B7Hxjzx6xc=; b=JKUATr3rjBmpPxDOBggqZBlfE/RQzXsgQZtQlRqwAleWcZR30ZhkHKnLwlZaMvOPCo laMhGX6kbHdvOjA1ZfAqSjq/TnsDktwHnudzx9qSOGg67TCnL2vVGGVxp/XU5YaCHmg0 6QHKDI/8YywZ7T/FA9ktjNT7PeIe751f7FS2MZT2k6Bbgz2RXVGnvSqaEWpa4F650Xce YFQEMMIh0kTyEWn/gVDxIXAJJygCcDKTPORHhkXU7MVbgLXUluNg7vj4ufiCAHjnmWRi QWmOZCQBbcN7JSzWg0pjWDjbbO9K5TiIwRDOF0RVfRlGDktQ+2Bebxh5qL3eijO8Rh0D NZ4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eKYX+CBV81RDb2zb68+tE3JHzZCrSEBZ6B7Hxjzx6xc=; b=P6SKsDKv8U4wCpPIJMH/aT61qcNNoGECOwAOvmg0FGBR1EEPyUStn3maQiNdXvjnsD go9V14PkpgfIOjtC81GBkf4wPHwH2b5q+Urhr1RieZ3DT/MoXsGndC61oqSdvmuD0jhe GyfUQSGr/rywZGneLtQwgOgmc4xJP+6uifOUtbRaeRxyC6G76HYzWnAu7it7nLQpLyeY WufmJk7w+IequdFOoFOUWOQ/+AtexWTzLN3vxRae7Q3EZu8h89N0R6Kw7IbcFv8s6D6R Tzim0/b35cEzK6xCzPMR/uibh/L4uc9ZaLSIKmnfon4kNE9LTLy1sOLrpGnnZTbpSMOv lh2A== X-Gm-Message-State: AKGB3mJ1anI9lUoUI8qmQhVhdKPtL1YG+UWqJV8Ncm7rimYrVDCIzQ1e rBxPhneuWxHajJUPfAY1S1Usjg3w0cvCuctaYJs5vg== X-Google-Smtp-Source: ACJfBovJCWW6dUGI2ZiVx3amTvqKuSikgxIzL3EpoesqCJv0w4CJrS6725kuqbaAgr3pxqT4xlUb5P7LbfmJmdBIvDc= X-Received: by 10.31.169.202 with SMTP id s193mr17099175vke.126.1513450784253; Sat, 16 Dec 2017 10:59:44 -0800 (PST) MIME-Version: 1.0 References: <201712160542.vBG5grwS007544@repo.freebsd.org> <20171216094433.GA37757@FreeBSD.org> <20171216103347.GA52930@FreeBSD.org> In-Reply-To: <20171216103347.GA52930@FreeBSD.org> From: Ben Woods Date: Sat, 16 Dec 2017 18:59:33 +0000 Message-ID: Subject: Re: svn commit: r456456 - head/misc/mc To: Alexey Dokuchaev Cc: Ben Woods , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Dec 2017 18:59:45 -0000 On Sat, 16 Dec 2017 at 11:33 pm, Alexey Dokuchaev wrote: > On Sat, Dec 16, 2017 at 09:44:33AM +0000, Alexey Dokuchaev wrote: > > On Sat, Dec 16, 2017 at 05:42:53AM +0000, Ben Woods wrote: > > > New Revision: 456456 > > > URL: https://svnweb.freebsd.org/changeset/ports/456456 > > > > > > Log: > > > misc/mc: Update to 4.8.20 > > > > This version also suffers from notoriously known "screen contents not > > preserved (or restored) when hiding/showing panels with Ctrl-O" bug. > > > > Last time the bug was fixed (after it resurfaced again) in r374372; > > mc(1) behaves correctly as of version 4.8.14 on 8.4-STABLE here. I'll > > try to find one when it got broken again but that may take some time. > > It got broken with r414983 (r414982 behaves correctly), that's 19 months > ago! It's surprising that the bug survived unfixed for such a long time. > > Shall I file a PR for that, or you'd rather take care of it without the > needless bureaucracy Ben? > > ./danfe > > P.S. Ironically, older versions have another annoying bug: typing in > commands with options (that is, typing dash aka minus) is impossible > because dash is treated as "unselect" command. *facepalm* Hi danfe, Please do raise a PR or perhaps an upstream bug report. I suspect this upstream report matches your problem. http://midnight-commander.org/ticket/2633 When reporting, please include details such as: 1. which shell you are using (does this happen for both sh and csh), 2. Which terminal you are using (xterm in X11 or local console). Does it affect both? 3. whether you are using SLANG or NCURSES option when building mc (does it affect both?), 4. whether you are having this problem as the root user or a non-privileged user. I have heard report of this problem, and seen it myself once upon a time, but it is not always easy to replicate. This problem was resolved once before, but the code being fixed by a local patch in our ports tree was changed. The patch needs to be fixed. https://svnweb.freebsd.org/ports/head/misc/mc/files/patch-lib_tty_tty-ncurses.c?view=log Regards, Ben > -- -- From: Benjamin Woods woodsb02@gmail.com