From owner-svn-ports-all@freebsd.org Mon Jul 4 07:14:45 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A43F9B915A7; Mon, 4 Jul 2016 07:14:45 +0000 (UTC) (envelope-from brnrd@FreeBSD.org) Received: from smtp01.qsp.nl (smtp01.qsp.nl [193.254.214.162]) by mx1.freebsd.org (Postfix) with ESMTP id 5198E277C; Mon, 4 Jul 2016 07:14:45 +0000 (UTC) (envelope-from brnrd@FreeBSD.org) Received: from smtp01.qsp.nl (localhost [127.0.0.1]) by smtp01.qsp.nl (Postfix) with ESMTP id EA4072A0CCA; Mon, 4 Jul 2016 09:14:34 +0200 (CEST) Received: from mail.brnrd.eu (unknown [193.164.217.85]) by smtp01.qsp.nl (Postfix) with ESMTP; Mon, 4 Jul 2016 09:14:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=brnrd.eu; h=date:from:to:subject:message-id; s=default; bh=4ijnIZ19zccWnKhfmRFazTLqmaowG4hN/fBN115GV68=; b=oMljcIzjZasq1YrZvQDF3teBPKQCu9B0nWRoQhZ8tMu6cDelgfw8JvtrJVGZ0yTzwnCciqIDQKq3BTetDlqPWD+3sgWYkExcKL6tQFB650e9FsVWvKmSo1j7o/xtNopOUJrlYQC3eUxrDaLK+wSJAfSfKVTm9F6rn0osZrsmM0u9wHpEglo2kR+IWypnTNevaIV8jLwsX3XZuCQ0uMova9N7eMDhzPTs/kXJVxlevbT/XSSL9botsafkntBIel71RH96A/FbBD+KSWv5jXxgxsoTicXCMl/13x+tecs3VeAti3moaJvKG9/aTU4tRtmLPdtNVUeGDd2r3aBcMogXwQ== Received: by bachfreund.nl (OpenSMTPD) with ESMTPSA id de8409a2 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO; Mon, 4 Jul 2016 09:14:33 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 04 Jul 2016 09:14:33 +0200 From: Bernard Spil To: Jason Unovitch Cc: Mathieu Arnold , Adam Weinberger , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r417795 - head/security/letskencrypt In-Reply-To: <20160703222715.GA38987@Silverstone> References: <201606292055.u5TKtOwU090876@repo.freebsd.org> <08FF4FCE-BAD2-4F26-9082-FE04378133B0@adamw.org> <36C82FFBA7D42A621D21CE03@atuin.in.mat.cc> <20160703222715.GA38987@Silverstone> Message-ID: X-Sender: brnrd@FreeBSD.org User-Agent: Roundcube Webmail/1.2.0 X-SMTP-Virus-Scanned: clamav at smtp01 X-Spam-Status: No, score=1.6 required=5.0 tests=HK_RANDOM_ENVFROM, HK_RANDOM_FROM,UNPARSEABLE_RELAY autolearn=disabled version=3.4.1 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on svfilter02.qsp.nl X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2016 07:14:45 -0000 On 2016-07-04 0:27, Jason Unovitch wrote: > On Thu, Jun 30, 2016 at 11:19:20AM +0200, Bernard Spil wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> On 2016-06-29 23:11, Mathieu Arnold wrote: >> > +--On 29 juin 2016 15:04:28 -0600 Adam Weinberger wrote: >> > |> On 29 Jun, 2016, at 14:55, Bernard Spil wrote: >> > |> >> > |> >> > |> +USES= gmake ssl:libressl tar:tgz >> > | >> > | Is USES=ssl:libressl real? It seems like a great idea, but I didn't know >> > | it was a thing. >> > >> > It's about the same as USES=ssl:foobar :-) >> >> Just figured this out as well :D >> >> Luckily it is a no-op, the ports framework just makes it ssl_ARGS >> which >> is not used in Mk/Uses/ssl.mk. >> >> The port takes care of the problem at the bottom of the Makefile >> >> .if empty(SSL_DEFAULT:Mlibressl*) >> IGNORE= needs LibreSSL to build. set DEFAULT_VERSIONS+=ssl=libressl \ >> and rebuild all ports that depend on openssl >> .endif >> >> which matches either security/libressl or security/libressl-devel. >> > Can you fix the ssl:libressl then? It doesn't make much sense to have > this non-functional line in the port. Hi All, Will do! There's a snafu in the periodic script as well that needs fixing. I've started re-working the LibreSSL dependency in the makefile to mimic the dependencies in Mk/Uses/ssl.mk BUILD_DEPENDS= libtls.so:security/libressl RUN_DEPENDS= libtls.so:security/libressl The IGNORE if SSL_DEFAULT is not set to a libressl port is a bit wide, wouldn't a nice big fat WARNING do? I intend to add a pkg-message as well to notify the user what path he's travelling down. Bernard.