Date: Mon, 5 Nov 2012 16:26:17 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r242625 - in head/sys: dev/ale dev/ata dev/ata/chipsets dev/ath/ath_hal/ar5212 dev/bge dev/cas dev/dc dev/flash dev/fxp dev/gem dev/lge dev/mii dev/nge dev/pci dev/re dev/sis dev/ste de... Message-ID: <CAJ-Vmokw1_=hcXp8xwdH8coFDF3YDE_NkBPP5Sffj9xrh500Ng@mail.gmail.com> In-Reply-To: <5098416C.3040802@FreeBSD.org> References: <201211051916.qA5JGRDr064585@svn.freebsd.org> <CAJ-VmokCiKJvUriXgDO91-2u4RgwyffHcCzgGW_wFxuOtkvpbg@mail.gmail.com> <5098416C.3040802@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5 November 2012 14:45, Dimitry Andric <dim@freebsd.org> wrote: > On 2012-11-05 23:36, Adrian Chadd wrote: >> >> I'm fine with the change, but why didn't you run this by the various >> driver owners first before doing a drive-by commit? > The change was trivial, and did not cause any binary difference. I see > no reason to bother 20 different maintainers with something like this, > except bureaucratic ones... :) It's less bureaucracy and more "common courtesy." I mean, _I_ think this change was fine as it didn't change things, but it could have easily been something bigger. We're playing in the same sand-pit, please don't just magically assume that stomping on my area without asking first is appropriate - especially if you think it's "a trivial problem, why would they mind?" That's exactly the reason you should ask. :-) Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmokw1_=hcXp8xwdH8coFDF3YDE_NkBPP5Sffj9xrh500Ng>