From owner-svn-src-head@FreeBSD.ORG Tue Nov 6 00:26:18 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3345EEDE; Tue, 6 Nov 2012 00:26:18 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by mx1.freebsd.org (Postfix) with ESMTP id DFCB28FC0A; Tue, 6 Nov 2012 00:26:17 +0000 (UTC) Received: by mail-pa0-f54.google.com with SMTP id bi1so4547977pad.13 for ; Mon, 05 Nov 2012 16:26:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=wf3TfonCA7+pi9LtiLRGnvnf0ggSPz6rRshLrMCWYU0=; b=NWHcuz1D3GN96N1srKmjnodKrhzVyXEEkfSUQNS2Z9Dm2KR6HSD9C63ucFbx6dWR0H tdk+gsMoje/hPnlgw9W7nhgA60ao1hf++r9v2vx/OgRCX3AxXVefhBgB3ZayMvkyR+4m o0Hhd3ASYu2qiyW7tyIZWcBYvwIN6+G1u3/3QGJ60O/Kofr2K7QgBuonnPKA0daTbjYX N8krEBHbt4utmBywS94ITxyUWA5JvFHqzngV8FJkiEGySBxrouexKQh2iP8MY+JYDPI1 zT8JYv4bNcb9YmkLyxn3Q8uiypdPhOPf8b9dkgfWSeXZvKX7/z3KFZp9LLtWBtHP+csa V5hQ== MIME-Version: 1.0 Received: by 10.66.87.105 with SMTP id w9mr33260077paz.5.1352161577089; Mon, 05 Nov 2012 16:26:17 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.68.124.130 with HTTP; Mon, 5 Nov 2012 16:26:17 -0800 (PST) In-Reply-To: <5098416C.3040802@FreeBSD.org> References: <201211051916.qA5JGRDr064585@svn.freebsd.org> <5098416C.3040802@FreeBSD.org> Date: Mon, 5 Nov 2012 16:26:17 -0800 X-Google-Sender-Auth: A2ok5heVkG7OL-Tb2KyhVN6BWgk Message-ID: Subject: Re: svn commit: r242625 - in head/sys: dev/ale dev/ata dev/ata/chipsets dev/ath/ath_hal/ar5212 dev/bge dev/cas dev/dc dev/flash dev/fxp dev/gem dev/lge dev/mii dev/nge dev/pci dev/re dev/sis dev/ste de... From: Adrian Chadd To: Dimitry Andric Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2012 00:26:18 -0000 On 5 November 2012 14:45, Dimitry Andric wrote: > On 2012-11-05 23:36, Adrian Chadd wrote: >> >> I'm fine with the change, but why didn't you run this by the various >> driver owners first before doing a drive-by commit? > The change was trivial, and did not cause any binary difference. I see > no reason to bother 20 different maintainers with something like this, > except bureaucratic ones... :) It's less bureaucracy and more "common courtesy." I mean, _I_ think this change was fine as it didn't change things, but it could have easily been something bigger. We're playing in the same sand-pit, please don't just magically assume that stomping on my area without asking first is appropriate - especially if you think it's "a trivial problem, why would they mind?" That's exactly the reason you should ask. :-) Adrian