From owner-freebsd-net@FreeBSD.ORG Fri Apr 20 15:20:29 2007 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2C0B916A403 for ; Fri, 20 Apr 2007 15:20:29 +0000 (UTC) (envelope-from bms@incunabulum.net) Received: from out4.smtp.messagingengine.com (out4.smtp.messagingengine.com [66.111.4.28]) by mx1.freebsd.org (Postfix) with ESMTP id 06CB913C489 for ; Fri, 20 Apr 2007 15:20:28 +0000 (UTC) (envelope-from bms@incunabulum.net) Received: from compute2.internal (compute2.internal [10.202.2.42]) by out1.messagingengine.com (Postfix) with ESMTP id 74E1721760B for ; Fri, 20 Apr 2007 11:20:30 -0400 (EDT) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute2.internal (MEProxy); Fri, 20 Apr 2007 11:20:29 -0400 X-Sasl-enc: NBq5lMzVa6st4vveEf3gOdvxuRBiT2TPtB6kd/QNkkJu 1177082428 Received: from [192.168.123.18] (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTP id 84D3F2942D for ; Fri, 20 Apr 2007 11:20:28 -0400 (EDT) Message-ID: <4628DA3A.3050309@incunabulum.net> Date: Fri, 20 Apr 2007 16:20:26 +0100 From: Bruce M Simpson User-Agent: Thunderbird 1.5.0.10 (X11/20070407) MIME-Version: 1.0 To: FreeBSD-Net mailing list Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: MFC of ether_input() changes X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2007 15:20:29 -0000 Hi, Does anyone want to see these changes MFCed, or otherwise object to such an MFC? The introduction of M_PROMISC did the following: * Drop frames immediately if the interface is not marked IFF_UP. * Always trim off the frame checksum if present. * Always use M_VLANTAG in preference to passing 802.1Q frames to consumers. * Use __func__ consistently for KASSERT(). * Use the M_PROMISC flag to detect situations where ether_input() may reenter itself on the same call graph with the same mbuf which was promiscuously received on behalf of subsystems such as netgraph, carp, and vlan. * 802.1P frames (that is, VLAN frames with an ID of 0) will now be passed to layer 3 input paths. * Deal with the special case for CARP in a sane way. For end users the main change of interest will be the ability for FreeBSD to receive 802.1p frames, even if it doesn't do anything with the priority fields right now. If I hear 'yeses' I will try to MFC this as time permits. Regards, BMS