From owner-svn-src-all@FreeBSD.ORG  Sun Jul 14 02:33:03 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id AB7E091;
 Sun, 14 Jul 2013 02:33:03 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-wi0-x232.google.com (mail-wi0-x232.google.com
 [IPv6:2a00:1450:400c:c05::232])
 by mx1.freebsd.org (Postfix) with ESMTP id C73C14E47;
 Sun, 14 Jul 2013 02:33:02 +0000 (UTC)
Received: by mail-wi0-f178.google.com with SMTP id k10so1816871wiv.5
 for <multiple recipients>; Sat, 13 Jul 2013 19:33:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=1aOeNYDAK4gY4uwa/0HwleTGkWS61GifDLDrl1KGXFw=;
 b=pndEqMetNqDvxnVKBCruIbRAd/XEWlqNsUtRvo3qfSTacK/wMHpfY+FdFNPVvh7a5B
 YbjyR/lmv2/7CF9obCUFSsNGQIh4o+yhrmbYwT5ZApJU7J9c1VD+DCef0l9ZTUqfbEhA
 xRqmpuAbhlHEH7DYMOTcIbbAr6bqJ9r2+CoS/R42DXanNFGCoVaHIGHMGw3dg/e0aefO
 y4QY/W/c4Uhs/BMBFBe/Ey6Z8i/VAlP/S76wzo8oAyCPfJtaJ+LZ5dkOtc8W0TNad1l7
 885YvCN2j3L0GYsMtC3m4KG38mkNh95DVYyULfeabmTVHVRNjJ/840XRz5pubr7lgjyj
 HtXw==
MIME-Version: 1.0
X-Received: by 10.194.63.229 with SMTP id j5mr27241502wjs.79.1373769181786;
 Sat, 13 Jul 2013 19:33:01 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.217.94.132 with HTTP; Sat, 13 Jul 2013 19:33:01 -0700 (PDT)
In-Reply-To: <20130713082158.GD2757@gmail.com>
References: <201307130425.r6D4P31J078644@svn.freebsd.org>
 <20130713082158.GD2757@gmail.com>
Date: Sat, 13 Jul 2013 19:33:01 -0700
X-Google-Sender-Auth: BQPl58bo8j2CEJJj5t3TwGQAnN0
Message-ID: <CAJ-VmokzUD_iW-6Guhawg+9xwJHnoPR=N3=tKHaxYNBVrmbu0A@mail.gmail.com>
Subject: Re: svn commit: r253314 - head/sys/net
From: Adrian Chadd <adrian@freebsd.org>
To: Mikolaj Golub <trociny@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Jul 2013 02:33:03 -0000

I'll double-check at work on Monday and commit an update.

Thanks!


-adrian


On 13 July 2013 01:21, Mikolaj Golub <trociny@freebsd.org> wrote:
> On Sat, Jul 13, 2013 at 04:25:03AM +0000, Adrian Chadd wrote:
>
>> +static int
>> +lagg_sysctl_active(SYSCTL_HANDLER_ARGS)
>> +{
>> +     struct lagg_softc *sc = (struct lagg_softc *)arg1;
>> +     struct lagg_port *lp;
>> +     int error;
>> +
>> +     /* LACP tracks active links automatically, the others do not */
>> +     if (sc->sc_proto != LAGG_PROTO_LACP) {
>> +             sc->sc_active = 0;
>> +             SLIST_FOREACH(lp, &sc->sc_ports, lp_entries)
>> +                     sc->sc_active += LAGG_PORTACTIVE(lp);
>
> Shouldn't sc be wlocked here?
>
>> +     }
>> +
>> +     error = sysctl_handle_int(oidp, &sc->sc_active, 0, req);
>> +     if ((error) || (req->newptr == NULL))
>> +             return (error);
>> +
>> +     return (0);
>> +}
>
> --
> Mikolaj Golub