From owner-freebsd-bugs Fri Jul 16 9:20: 4 1999 Delivered-To: freebsd-bugs@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 7919A14D50 for ; Fri, 16 Jul 1999 09:20:02 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id JAA61531; Fri, 16 Jul 1999 09:20:02 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Date: Fri, 16 Jul 1999 09:20:02 -0700 (PDT) Message-Id: <199907161620.JAA61531@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Garrett Wollman Subject: Re: misc/10231: inet_addr() doesn't check for illegal values in Reply-To: Garrett Wollman Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR misc/10231; it has been noted by GNATS. From: Garrett Wollman To: John Polstra Cc: freebsd-gnats-submit@FreeBSD.ORG Subject: Re: misc/10231: inet_addr() doesn't check for illegal values in Date: Fri, 16 Jul 1999 12:17:34 -0400 (EDT) < said: > Yes, it's a bug. The patch has the right idea but it isn't quite > right in all the details. For example, in the first chunk of the > patch: > Also, in the second chunk of the patch, under case 3, there's a bug. > The line should read: Actually, the whole function should be rewritten to use strtoul() rather than hand-rolling Yet Another integer parser. -GAWollman -- Garrett A. Wollman | O Siem / We are all family / O Siem / We're all the same wollman@lcs.mit.edu | O Siem / The fires of freedom Opinions not those of| Dance in the burning flame MIT, LCS, CRS, or NSA| - Susan Aglukark and Chad Irschick To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message